[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vpci: Add resizable bar support
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Thu, 21 Nov 2024 03:05:14 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mhqu8/W+pFtKyKzE+BRLMZ4QVAxhR3VAwRKov0gvA2A=; b=l5v7RPO03BgGUlBeHX30/KLL6Enw111pFMybNfHkjRcMz1OwJ3w4Jq797T0CxZScS/2XoaYgJ6zou30X5JOVZ1Q0Ya3aZhgT1BjtLRKZ/gkSEq8zKRyyZN4G2h3RTrghvYeF6As/+ZYYpdPBoylKNLXLFzmFDHTA7i6zn8bgjR8bUwqTlw+yIUmPUaHIAHNnCgsPVgSN+8cdWewcvqN/XmKXWV1IrLeHqvvf/R75kwLaEWYGjQWK2aGa39DRv4yQWZj5AmK0Df58SKVMCaQm8QDbmiKyCqc/EZcXtO+FJ10k/oZ++2lBDKEpmQsUTiOxzzUGIE1V81RxsVbAsbb6TA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DC7IWgj53dQafBU/d6IYH2g9NEONre5pt/0AIn/20cwrrL9+yNOJdPWQfePE3euEXcL8EyS8BVjUn1tQxbeXgFKQTfFX72L/mXFmfKc+fknvFLe0EE184Fuq2DKmFLudpk8ya1gI8/+Y4VB5AH+4o+bN22FkIurN68i+/mIIlHoz8du+s4mAvokh1YgCI/z78aX+VToZfELiFBd0MxUbC8OxrdEWTq0YJUSn3yfgQ0Az0O9doste4UIWH9qdPxT3BZAuN2CObE1XtfxkQ/pIOAde4l12jLZ/pr///pnlsLXG+xdBi3LRH4bqgPyVkjzv6mWNFJdotwlO3gb4L35VYg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Thu, 21 Nov 2024 03:05:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbNaIlMxf8mJcywkeNRFmHEai1qbK08gcAgACKfwD//4ZQAIABzRcAgAAfLACAAB0/gIABIxcAgAAMOoCABNwTAIABfwWAgAFxTQD//+JeAIABss4A
- Thread-topic: [PATCH] vpci: Add resizable bar support
On 2024/11/20 17:01, Roger Pau Monné wrote:
> On Wed, Nov 20, 2024 at 03:01:57AM +0000, Chen, Jiqian wrote:
>> The only difference between our methods is the timing of updating the size.
>> Yours is later than mine because you updated the size when the driver
>> re-enabled memory decoding, while I updated the size in time when driver
>> resize it.
>
> Indeed, my last guess is the stale cached size is somehow used in my
> approach, and that leads to the failures. One last (possibly dummy?)
> thing to try might be to use your patch to detect writes to the resize
> control register, but update the BAR sizes in modify_bars(), while
> keeping the traces of when the operations happen.
>
This can work, combine our method, use my patch to detect and write the size
into hardware register, and use your patch to update bar[i].size in
modify_bars().
Attached the combined patch and the xl dmesg.
--
Best regards,
Jiqian Chen.
Attachment:
rebar_xl_dmesg.txt
Description: rebar_xl_dmesg.txt
Attachment:
0001-combine-two-method.patch
Description: 0001-combine-two-method.patch
|
