[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/4] common/vmap: Fall back to simple allocator when !HAS_VMAP
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 25 Nov 2024 16:30:04 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BpQRabkWGjn7Z5I94H8240NDLwxcjDruRmPz0q+Ya2g=; b=VEk+jQFMfTbdqULZDHz5FM5nthXeeO1Llwwyzd9Geh4Cdt4XU53rkNcUE8ZrhJtnoeEqSBtcjBWgqb1kDUMpoWe0hwBY5FOkjLCAb26j8znCNQlzflTqt3n0vL2lWfq7TyffQpIsvfK1/nHybMBE5AkaFBDquBM9cWITV7P+yywMwnIebGQoUeFtYL4Cwa7Kw9Yua9QcvR5oj6pNQvcKyojVqoQbmaaGPJgdtDo+5YM+aQcn9mfhAYhehuNxYQqHiszOfq38P5G0T9OAPBiBW9eAQe1mjrlgucHfndagEbjdqPUXhSrSXetbAUzfQolboQDIMAQfyT1DFdG36ubHYg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BpQRabkWGjn7Z5I94H8240NDLwxcjDruRmPz0q+Ya2g=; b=dy9kOS144pd0nuiHGrEmOAt+Xjr1IGgN+rucQxItXulSaNXQTfawIbbU6UvPz2KHtR+AVknucFIqJybymTawt1eSt2S45SB1k1t5Jsz2I0Q35a7EUTtnwfCMY/jo64iuny/ULxZiYeHdS9y5QqM26SiPJ7vxeF3r3hkRRXAHevfieWtSUiicoaodKTPSir5OkIP2QRFneSlsO//tuJp0FKOInLSG2MO/Tait76S7IIlwu4kUf9yZGq2vjhos4tzZqao/NPNcpaRcxAn4huR8FyYh9LavMiVebEwkMFebXUTVgixaYX/CfMiBbPgComTQHwJ5IZ5gYVwvk+YbuCmVsg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=Jr8wHWgvzDgai/is2aMyugd8I+n3+Tz1Pc5EQxl3JBJpJnLq15rdDZU2Ugto404lBQxJA4OPje/9VCUPE6/zqWzo7RZ3zvAmgPVmo87a5kvscqwLw9/Cb6va0oXCQTq+SdsviI5LVf+hxUh3hKXIQSGEkTrTXyDeW5wW5OSx1WKxvlMFwr8f3m+rfIUE1q2E7ahwIrEocpiXfGb3HAJJ2euTvjkmS7s9X17YocFXJynY2HVw5rTJXfyV2ekcmUvXB8Je8qeh2hCtfwecTJaBMvHgjSa+Ry8siFq47zAd5YG1MsLbgtaORI0kT4JB71WBuVzWeqGf0cy9F9PZCedlpA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZflqJ79JCqCHyYBZiVeocl26N/bk6iD3I3zOzaEis1sJfgMmsE0YQjwbaTGwvrY3RMu6iLrWBoHqOqCuSFU4FwZxeZs4PMgtTVCRT09l6kSsOs1MMRROPzAbvG8S3R4Fw8HozarTgYwxn2iQokaEQjeKuwUt10mRhsPXoCg38ObMYkgffxBIVzjYb+ee9Mt0tfYIIu9FL/jNgUPK8JAHitMn5yb68sNJd/HxQsOqf+HDQQKPS4jDtPjttGcGClXLLxsSFULnvnnxtsCeThlF0SmAxsxQrt5HC+ssUwEAK+7gKUQSZnSeEY7Cj4NQsco1otgQ4VmbMSFZV9lxaOxHOg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 25 Nov 2024 16:30:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbOmE7YtVMCPerGUiym/x0EBbXBrLIN3IAgAACNoA=
- Thread-topic: [PATCH v2 1/4] common/vmap: Fall back to simple allocator when !HAS_VMAP
Hi Jan,
> On 25 Nov 2024, at 16:21, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 19.11.2024 09:58, Luca Fancellu wrote:
>> --- a/xen/include/xen/vmap.h
>> +++ b/xen/include/xen/vmap.h
>> @@ -5,12 +5,19 @@
>> * purpose area (VMAP_DEFAULT) and a livepatch-specific area (VMAP_XEN). The
>> * latter is used when loading livepatches and the former for everything
>> else.
>> */
>> -#if !defined(__XEN_VMAP_H__) && defined(VMAP_VIRT_START)
>> +#ifndef __XEN_VMAP_H__
>> #define __XEN_VMAP_H__
>>
>> #include <xen/mm-frame.h>
>> #include <xen/page-size.h>
>>
>> +/*
>> + * MPU systems won't have HAS_VMAP enabled, but will provide implementation
>> + * only for some of the functions of this module. So hide the definition for
>> + * some of these function to systems where !HAS_VMAP
>> + */
>> +#ifdef CONFIG_HAS_VMAP
>
> What you're hiding are declarations, not definitions.
yes, I realised the mistake after sending
> While this may feel like
> splitting hair, the question really is: Do the declarations actually need
> hiding? IOW won't it suffice to have the definitions unavailable? While this
> would mean that wrong uses are flagged only when linking, we do such all the
> time when we expect e.g. DCE to remove actual uses of respective identifiers.
I misunderstood your comment on the previous version and I thought your
preference
was to hide the declarations. I’ll try without hiding them and I’ll send the
change soon.
Cheers,
Luca
|
