[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/15] x86/hyperlaunch: introduce the domain builder


  • To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Mon, 25 Nov 2024 15:23:14 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=apertussolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z2IBpHKf/FfD+ytFu+hb1KXEoec18VgnUzjoAPbkAns=; b=VUlACeoFqCTECbLNctJlUvpkGOAM8LjBfo9h06k6nstlpYrVEmKd9aN9i7DSwAvpjms4xst0IxaA6cPXvgVTRexgoS4dMHQR+J7eVeMjnJ1ih+jFZvtT/XOhQmsWOUTbVFjWjlzHiFKx5vfIeiMsUO39MNyv3NLM0xPbgMi0VosA4Og45THmTzRZ89zIv6vgiZo47d7N1/nXxvLfUhk1CtjNYnFTKq7wjYvtFdLGuLXu+kTijlxcEJ4Jzows06mBOG20he73ZEH4huOgakddOQzFqI9scw0tC61uS2sRUR/F2We4k9nrQifmo2tIv/heFxtD8oCH18P6LzgRgS/4eg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ui3BaD3lADjIh1VQHtw6YraMhdLf1nGFuT1Cy70vEeL0IyzSRs3mVL545kbrvBAVZPGSCLFuYu2j8b0EIWpsgl54MVtt/ORtgW8SPu7iNVGQE6ZAV3ufumNXT+gi2yYbnbKMwsd+YKGksX4eqR4o08BDBbOwNdBJ1mAZrH2iwqhWZQUhOtIky7fg7/xraohNH7E/zCfIIJQk1lmI57W1h/JZSjps7ObxnDmlsHDMWR+lampRqb2l2R/ne3ZartgMiujXuW4UbWGhPFOGuKMUMrtklusJSXLwmNoQiiNj8nbOUX3NChhMRzgHao6Y7jeHoIq/xfNACjnylHicikS8mw==
  • Cc: <christopher.w.clark@xxxxxxxxx>, <stefano.stabellini@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 25 Nov 2024 20:23:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2024-11-25 12:52, Jason Andryuk wrote:
On 2024-11-23 13:20, Daniel P. Smith wrote:
+void __init builder_init(struct boot_info *bi)
+{
+    if ( IS_ENABLED(CONFIG_DOMAIN_BUILDER) )

... then this extra level of indent isn't necessary (with an empty static inline builder_init()).

I guess this way, this small part is compiled even when CONFIG_DOMAIN_BUILDER is disabled.  But it's only a piece, so I'm not sure if it's worth it.

Later in the series, I see more code is added here for non-Hyperlaunch. Disregard this comment.

Thanks,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.