Re: [PATCH v7 10/11] Arm32: use new-style entry annotations in head.S

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 01/10/2024 16:17, Jan Beulich wrote:
> Locally override SYM_PUSH_SECTION() to retain the intended section
> association.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> v7: New.
>
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -48,13 +48,20 @@
>   
>           .section .text.header, "ax", %progbits
>           .arm
> +/*
> + * Code below wants to all live in the section established above.  Annotations
> + * from xen/linkage.h therefore may not switch sections (honoring
> + * CONFIG_CC_SPLIT_SECTIONS).  Override the respective macro.
> + */
> +#undef SYM_PUSH_SECTION
> +#define SYM_PUSH_SECTION(name, attr)
Are you suggesting the code in arch/*/head.S has a latent bug?

The rest lgtm to me pending the clarification.

Cheers,

--
Julien Grall