Re: [PATCH 09/36] riscv/domain: introduce domain_has_vuart()

[oleksii.kurochko@xxxxxxxxx]

On Tue, 2024-11-26 at 15:21 -0800, Denis Mukhin via B4 Relay wrote:
> From: Denis Mukhin <dmukhin@xxxxxxxx>
> 
> Introduce domain_has_vuart() for RISC-V port to be used in the
> console driver.
> 
> Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
> ---
>  xen/arch/riscv/include/asm/domain.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/xen/arch/riscv/include/asm/domain.h
> b/xen/arch/riscv/include/asm/domain.h
> index
> c3d965a559b6ce3661bf17166d0c51853ff295a2..efbc4f1ea2619a187fe30ede17d
> 96de01e599220 100644
> --- a/xen/arch/riscv/include/asm/domain.h
> +++ b/xen/arch/riscv/include/asm/domain.h
> @@ -10,6 +10,8 @@ struct hvm_domain
>      uint64_t              params[HVM_NR_PARAMS];
>  };
>  
> +#define domain_has_vuart(d)         false
> +
>  struct arch_vcpu_io {
>  };

LGTM: Reviewed-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

Probably it would be nice instead of having stub ( #define
domain_has_vuart(d) false ) in arch specific code, just ifdef-ing it
and put somewhere in
<xen/domain.h> to not introduce this definition for each architecture
which doesn't support vuart now.

Thanks.

~ Oleksii