Re: [PATCH v3 5/5] xen/arm: Move setup_frametable_mappings to arm/mmu

[Julien Grall <julien@xxxxxxx>]

Hi Luca,

On 29/11/2024 09:12, Luca Fancellu wrote:
> diff --git a/xen/arch/arm/mmu/Makefile b/xen/arch/arm/mmu/Makefile
> index 2cb44b857dd2..1c89602947de 100644
> --- a/xen/arch/arm/mmu/Makefile
> +++ b/xen/arch/arm/mmu/Makefile
> @@ -1,3 +1,4 @@
> +obj-y += mm.o
>   obj-y += p2m.o
>   obj-y += pt.o
>   obj-y += setup.o
> diff --git a/xen/arch/arm/mmu/mm.c b/xen/arch/arm/mmu/mm.c
> new file mode 100644
> index 000000000000..aefec908b7f2
> --- /dev/null
> +++ b/xen/arch/arm/mmu/mm.c
> @@ -0,0 +1,61 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
arch/arm/mm.c is GPL-2.0-or-later. AFAIU, there are still disagreements 
within the committers on whether we can drop the "or later" for existing 
code. So I would suggest to keep the same license.
The rest LGTM.

Cheers,

--
Julien Grall