Re: [PATCH 1/1] xen/common: Remove dead code

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 19 Dec 2024, Ariel Otilibili wrote:
> The if-statement tests `res` is non-zero; meaning the case zero is never 
> reached.
> 
> Coverity-ID: 1055253
> Fixes: e2b1ebf4de ("x86: Support booting a bzImage format domain 0 kernel.")
> Signed-off-by: Ariel Otilibili <Ariel.Otilibili-Anieli@xxxxxxxxxx>

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> --
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Cc: Michal Orzel <michal.orzel@xxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Julien Grall <julien@xxxxxxx>
> Cc: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> ---
>  xen/common/gzip/inflate.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/xen/common/gzip/inflate.c b/xen/common/gzip/inflate.c
> index b9a2d7a23a..cb146555c8 100644
> --- a/xen/common/gzip/inflate.c
> +++ b/xen/common/gzip/inflate.c
> @@ -1164,8 +1164,6 @@ static int __init gunzip(struct gunzip_state *s)
>      if ( (res = inflate(s)) )
>      {
>          switch (res) {
> -        case 0:
> -            break;
>          case 1:
>              error("invalid compressed format (err=1)");
>              break;
> -- 
> 2.47.1
>