[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/20] accel/accel-cpu-target.h: Include missing 'cpu.h' header
- To: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx
- From: Richard Henderson <richard.henderson@xxxxxxxxxx>
- Date: Sun, 26 Jan 2025 12:40:34 -0800
- Cc: Peter Maydell <peter.maydell@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, qemu-arm@xxxxxxxxxx, Igor Mammedov <imammedo@xxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, qemu-ppc@xxxxxxxxxx, qemu-riscv@xxxxxxxxxx, David Hildenbrand <david@xxxxxxxxxx>, qemu-s390x@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Sun, 26 Jan 2025 20:40:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 1/23/25 15:44, Philippe Mathieu-Daudé wrote:
CPU_RESOLVING_TYPE is declared per target in "cpu.h". Include
it (along with "qom/object.h") to avoid when moving code around:
include/accel/accel-cpu-target.h:26:50: error: expected ')'
26 | DECLARE_CLASS_CHECKERS(AccelCPUClass, ACCEL_CPU, TYPE_ACCEL_CPU)
| ^
include/accel/accel-cpu-target.h:23:33: note: expanded from macro
'TYPE_ACCEL_CPU'
23 | #define TYPE_ACCEL_CPU "accel-" CPU_RESOLVING_TYPE
| ^
include/accel/accel-cpu-target.h:26:1: note: to match this '('
26 | DECLARE_CLASS_CHECKERS(AccelCPUClass, ACCEL_CPU, TYPE_ACCEL_CPU)
| ^
include/qom/object.h:196:14: note: expanded from macro
'DECLARE_CLASS_CHECKERS'
196 | { return OBJECT_GET_CLASS(ClassType, obj, TYPENAME); } \
| ^
include/qom/object.h:558:5: note: expanded from macro 'OBJECT_GET_CLASS'
558 | OBJECT_CLASS_CHECK(class, object_get_class(OBJECT(obj)), name)
| ^
include/qom/object.h:544:74: note: expanded from macro 'OBJECT_CLASS_CHECK'
544 | ((class_type
*)object_class_dynamic_cast_assert(OBJECT_CLASS(class), (name), \
|
^
Signed-off-by: Philippe Mathieu-Daudé<philmd@xxxxxxxxxx>
---
include/accel/accel-cpu-target.h | 3 +++
1 file changed, 3 insertions(+)
Acked-by: Richard Henderson <richard.henderson@xxxxxxxxxx>
r~
|