Re: [PATCH 7/9] hw/net: Have eTSEC device inherit from DYNAMIC_SYS_BUS_DEVICE

[CLEMENT MATHIEU--DRIF <clement.mathieu--drif@xxxxxxxxxx>]

Reviewed-by: Clément Mathieu--Drif<clement.mathieu--drif@xxxxxxxxxx>



On 25/01/2025 19:13, Philippe Mathieu-Daudé wrote:
> Caution: External email. Do not open attachments or click links, unless this 
> email comes from a known sender and you know the content is safe.
>
>
> Because the network eTSEC device can be optionally plugged on the
> TYPE_PLATFORM_BUS_DEVICE, have it inherit TYPE_DYNAMIC_SYS_BUS_DEVICE.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
> ---
>   hw/net/fsl_etsec/etsec.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
> index 781b9003954..3ce4fa2662d 100644
> --- a/hw/net/fsl_etsec/etsec.c
> +++ b/hw/net/fsl_etsec/etsec.c
> @@ -425,14 +425,12 @@ static void etsec_class_init(ObjectClass *klass, void 
> *data)
>       dc->realize = etsec_realize;
>       device_class_set_legacy_reset(dc, etsec_reset);
>       device_class_set_props(dc, etsec_properties);
> -    /* Supported by ppce500 machine */
> -    dc->user_creatable = true;
>   }
>
>   static const TypeInfo etsec_types[] = {
>       {
>           .name          = TYPE_ETSEC_COMMON,
> -        .parent        = TYPE_SYS_BUS_DEVICE,
> +        .parent        = TYPE_DYNAMIC_SYS_BUS_DEVICE,
>           .instance_size = sizeof(eTSEC),
>           .class_init    = etsec_class_init,
>           .instance_init = etsec_instance_init,
> --
> 2.47.1
>