Re: [PATCH v3 10/12] x86/fpu: Pass explicit xsave areas to fpu_(f)xsave()

["Alejandro Vallejo" <alejandro.vallejo@xxxxxxxxx>]

On Mon Jan 27, 2025 at 11:01 AM GMT, Jan Beulich wrote:
> On 10.01.2025 14:28, Alejandro Vallejo wrote:
> > No functional change.
> > 
> > Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
> > ---
> > v2->v3:
> >   * const-ified v in fpu_fxsave() (missing in v2)
>
> Sadly this has rendered ...
>
> > --- a/xen/arch/x86/i387.c
> > +++ b/xen/arch/x86/i387.c
> > @@ -129,7 +129,7 @@ static inline uint64_t vcpu_xsave_mask(const struct 
> > vcpu *v)
> >  }
> >  
> >  /* Save x87 extended state */
> > -static inline void fpu_xsave(struct vcpu *v)
> > +static inline void fpu_xsave(const struct vcpu *v, struct xsave_struct 
> > *xsave_area)
>
> ... this line too long now. With it suitably wrapped (possibly doable while
> committing, if no other reason for a v4 appears)

Bah, yes. You're right. I don't mind it being adjusted on commit.

> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Jan

Cheers,
Alejandro