[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/2] docs: fusa: Add the requirements for some of the commands of XEN_VERSION
- To: Julien Grall <julien.grall.oss@xxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 29 Jan 2025 15:49:02 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zio1Ob2iOtULBNc7H/FdduLNVGHP14O1EMaJZwRvXJo=; b=ApZN0zp/o/PZcWX/0KMI641onaacFjyltJMkh/EUuYMm5peY/zqXzjZ4iwaiMyngEoc28O9ZD1FvsFMlA40eArx5yU2flrkXoHO1HVdH63p9Zs5nP5XiPannoeRjCH4ENC5vUFh34BFkfzmOOPxVpqVMTfpOTRZW/aWnpp6yWBtLK2Ro1WD3Ra/puImzYx+/cAJFBTbgE3OsBWrMfycbkGIu5Wxl4GZLoOwWFSegmbRpQADHl/zDafhTQ66oem7hLb+vF7FgKsU1MUAvrpNzRedVptbpS5MjqNZgr9MSSRRw/PaoZM6vYYSEdcJstvD4hSc9IVIM23hliWdpI0PPNA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zio1Ob2iOtULBNc7H/FdduLNVGHP14O1EMaJZwRvXJo=; b=o2l60IjsY/efWOa308SYogTmSzHqTCr5oCRb/Oo3o2XCInmmS3Fi9JNNN4TVrkS8Ruu1xfDw4BJ3Z5bcTwoneSUwS+jd+xAq+d3m4TQ6CblTlNeLdyfbB5OuWhmQI3NboyPhDLgmCeAarZkSX2opARGxZufV50ex/yrh4UVqn/qknQJ/Wzgb3mfUswz9jfAN8ICh5qY4Auu35D8AplgYBVASYYuhd9BdnbCYYH48p2t7qPe1eW8WhkFgYMQ+FLRvzuIv7P+E0v3xwkKH92SvPZEiSKc9USqff1spFX+XfTd6Rw3SoNHpflzhV/EVKykgPr/Tk5qguINO8Dq1fOix1Q==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=snS/l2/0zd7Ix6qeqnD2ADtX8x0Vo7WYquU8qfHvW+dE3U+upK/PLeKFkO0kNQYfF8RcI3UP0FxCMF8UgQo4fJ0lsQRa+Rke74/i48Bl1NWBr2ATl5854KMVj309dBbrT/TMknhzfVs4ajVzJB0nMJ5AWAkq+IFiIFm3bEbf4pD/SrRjRGwHrV9MPtymVsKkDLFEw4wKUBi3e1yrtwNkL6l0Sq9WelGdWLvlKiAEgi5hO31RKxJliBVLvbfIHjDjNcC683jrhDQ33lIr7gspGFIZp4pU8LnFxEw570DYrdu5Rvta1BTUiKTVCrh8oEvdNhYkcpEeV7fWyK7vslPiVQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QLY+PPtsaLG/em6OUlXJdsgPPQKrptlWgx7XXy9qHdWmdGhbubsgufjHsFPNBcIOpbYlg15/FwMIB4XjK5f5CmQ9oj0hrmJgN9AMCtb9FI3g5bDm2HJfYq0xVFQ95eQViHoQ9oYUrm5z6I6Z90qPwM7AcJ54zKFBTc+NQGSOe9b/u8CaD4xn833Wuc8oTTappaBJpNQ5mL8I+q06NeuNQYUWP1fe0W72nDTwgArVeWTzCCFNKsxz6nm1Ug3uXnbzsamPn3DeLVDKVkk4jb9m/01mmJY1KKcJayN2/NJE+S6w4KNoZ6VFSPCU8c6cl8/cHH1q1scpanek3qMqjIRxYA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Artem Mygaiev <artem_mygaiev@xxxxxxxx>
- Delivery-date: Wed, 29 Jan 2025 15:49:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbZr2QpA/avZzDqk6Vb2qnMvbcCbMt+LgAgAAEYwA=
- Thread-topic: [PATCH v1 2/2] docs: fusa: Add the requirements for some of the commands of XEN_VERSION
Hi Julien,
Welcome back :-)
> On 29 Jan 2025, at 16:33, Julien Grall <julien.grall.oss@xxxxxxxxx> wrote:
>
> Hi,
>
> On Tue, 14 Jan 2025 at 16:50, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> wrote:
> We have written the requirements for some of the commands of the XEN_VERSION
> hypercall.
>
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> ---
> .../design-reqs/arm64/version_hypercall.rst | 33 ++++++++
> .../reqs/design-reqs/version_hypercall.rst | 65 +++++++++++++++
> docs/fusa/reqs/index.rst | 2 +
> .../reqs/product-reqs/version_hypercall.rst | 82 +++++++++++++++++++
> 4 files changed, 182 insertions(+)
> create mode 100644 docs/fusa/reqs/design-reqs/arm64/version_hypercall.rst
> create mode 100644 docs/fusa/reqs/design-reqs/version_hypercall.rst
>
> diff --git a/docs/fusa/reqs/design-reqs/arm64/version_hypercall.rst
> b/docs/fusa/reqs/design-reqs/arm64/version_hypercall.rst
> new file mode 100644
> index 0000000000..1dad2b84c2
> --- /dev/null
> +++ b/docs/fusa/reqs/design-reqs/arm64/version_hypercall.rst
> @@ -0,0 +1,33 @@
> +.. SPDX-License-Identifier: CC-BY-4.0
> +
> +Capabilities
> +------------
> +
> +`XenSwdgn~arm64_capabilities~1`
> +
> +Description:
> +Xen shall have a internal constant string storing "xen-3.0-aarch64".
>
> Can you explain why we need to specify how Xen is storing the string? At
> least to me this feels a bit overkill. What matters is what/how the VM is
> seen.
This is a design requirement and as such it should be testable so it would be
easier to have something saying:
Xen shall have a constant named XXX storing YYY.
Just saying "an internal constant" seem a bit limited here and not saying much
that could be tested easily.
Why do you think this would be an overkill ? do you expect the constant name to
change a lot ?
I would see more as an overkill the fact that the value is stored in a
requirement.
Cheers
Bertrand
|
