[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] automation: Add Arm64 MPU build job


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Thu, 3 Apr 2025 11:35:42 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H2Mo6Z1TodjxGYRpnAA31H0tyJUYgFl7YtnziJkp+9s=; b=gGoGm8oMczfHvNd5dj6wlPoR+tkiE258P/PfhtHaW0jI43tvSaJuIDKbYO/Un/lJUfQCex8oI9WpHsFqSsWCtSvhQmKWYqKkxEG0my5/3WR33H5pnKI5kU6VJ1hpfbMe0zw4fQ482X8g+L8yl0/rHyS3ehZP5HCF1Pri/8p2K9XwtqwPUIWecylWDVl/oVcFoXW1D4NdPxNxxjHG/EHtnU9jiY/vHQ6L9sahtQtaopTHWWQZFIESmT0lSM4VIb2cgIP8r5t5gFsytLRa+VHZVVRkRBUuvkAi6aXM7biiLnb6psLYMJ8qgsjVjiLQdD5yGa55IglDAmbd24rpmFrUHw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sv9jqQQP85TheNWqgopVDvEk8hro7QI2ObbhO52rK8opPahHbk7verw9LGaA8KnTW/crpT6UZ0dG5QA482MiFrucYXsATPGXNyzYIf3CkUpx/8XLCjw57d42UdiAKtPBMxHBtueU0WAd5V8/DGNJJepO1I+mt8HRX96CePQ4BB5XGYdKLl1pvPQ8RpdOXm+Q2IfVtmlS3/1ghSt3DKXRkTErvXdp/pISOm2EcwHFVbSrmEoE+IEjHXdzKg9UiX0nDTPwHCOCJvlDNxhD86efMXaqzQNtB2KM8WBUYEy/nuyxFyaClmrqBjM3WpXKU1B34lt3N5jzm4FkD4IIityqsw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 03 Apr 2025 09:35:58 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 03/04/2025 11:28, Jan Beulich wrote:
> 
> 
> On 03.04.2025 11:17, Orzel, Michal wrote:
>> On 03/04/2025 10:58, Jan Beulich wrote:
>>> On 03.04.2025 10:44, Orzel, Michal wrote:
>>>> On 03/04/2025 10:43, Jan Beulich wrote:
>>>>> On 03.04.2025 10:19, Michal Orzel wrote:
>>>>>> Just like for RISCV and PPC, the earlier we enable the CI build the
>>>>>> better.
>>>>>
>>>>> What about Arm32?
>>>> The series to enable compilation of Arm32 with MPU is still under review 
>>>> on the ML.
>>>
>>> Oh. Is MPU in Kconfig then missing a dependency on 64BIT?
>> Well, yes you're right although when I think about it, it's been like that 
>> (for
>> both 64 and 32) since the introduction of CONFIG_MPU by commit (in October 
>> last
>> year):
>> 0388a5979b21 ("xen/arm: mpu: Introduce choice between MMU and MPU")
>>
>> If you're saying that all the Kconfig combinations + targets like 
>> allyes/allno
>> need to build successfully also for new ports (MPU on Arm is kind of like a 
>> new
>> port), then I agree (I did not think about it and clearly others too seeing 
>> the
>> MPU patch above) although I'd prefer to avoid sending a patch adding 
>> dependency
>> just to be removed in 1-2 weeks. But I can do whatever you think needs to be 
>> done.
> 
> I'm far from insisting on a change here; you're a maintainer of that code 
> while
> I am not. Yet I indeed think Kconfig needs to have the dependencies right, or
> else randconfig CI jobs may randomly fail.
Sure, thanks for showing understanding.

A different question (also to other people who knows this stuff).
MPU requires to specify Xen start address using CONFIG_XEN_START_ADDRESS that is
set to invalid default value to catch user attention. Provided that randconfig
can select UNSUPPORTED and MPU, we should somehow set CONFIG_XEN_START_ADDRESS
to e.g. 0 to be able to build successfully. Is this where we need to add
EXTRA_FIXED_RANDCONFIG to existing arm64 and arm32 randconfig jobs?

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.