[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/3] xen/arm: Move some of the functions to common file
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 7 Apr 2025 11:04:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x/hXzcNFjPfGx2p5Fmcz3iqPzNX/iGxr6ouwRZfOXGg=; b=XoqdGH9hDA+9Eb6UY1ujrh21Y++xNXoE+STTc1KMmRFPLs8Akob+oaJ3p3yC0j5NSSnoc19LJfGWriEBg+NhUC0zcnf9r+lTpamsep1y3t8NNoJG6oFfEQlGu1tmJy/KIlJ6BdnqJmHh5LmFpeheoHLdQgwvXbZ7abHDf+c6OPL6x1kWW86t3jk2dLcNq9vczxhYiSl0DWrRbAjCAKmfR8dCv+7+rr6A7L1TbMHFkfo8rD4ULEswJTrj9ABvWtIlV440VVs4pyFg6Ajsa41vzI+G1mD4o+AFX9Eb+dr7JVO3v/ld10UcKGChRdAwOT7o7PGc1NZ6/XdGGf1uKu5vwQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mQ5xqhrXczcdHwTaEus0ZKftFW2MOilTFVvPkOBb2zUFj9naVbj37+XXO7Q5s5V/s2oL0XUXe7nY5eH0PQoz2DiX0EZ8NQmY/EB68yX2ps3w7Su5kR4/3u2I8aGiCgW6OLSmDeaYPqpasmV0e6vY+pI+psCK1PVQpjM8nODzTiVzs+I+ugrxS7gjHVNbEkcO9Sn/bGz/CuSwayPhzgiTeTuMb4ucqEeBZtxAXZbTFAlU/g9eHgaThNZ2YXXqsdaBfeEDCf0BthfSa/C9jXu+IyQfZaodstiuqB/anPxZLeC2eWo0LHHYsGp7Zbsw92xbXR1bGdfpndHZ21TlYF9kRg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 07 Apr 2025 09:04:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03/04/2025 19:12, Ayan Kumar Halder wrote:
> Added a new file prepare_xen_region.inc to hold the common earlyboot MPU
> regions
> configurations across arm64 and arm32.
>
> prepare_xen_region, fail_insufficient_regions() will be used by both arm32 and
> arm64. Thus, they have been moved to prepare_xen_region.inc.
>
> enable_secondary_cpu_mm() is a stub which is moved to prepare_xen_region.inc
> as
> SMP is currently not supported for MPU.
This does not sound right. If you want a place to keep some common MPU stuff
between Arm64 and Arm32, you need to come up with better name for a file. SMP
has nothing to do here with preparing regions so it feels odd to have
enable_secondary_cpu_mm stub there.
Also, new files should use dashes '-' and not underscores '_'.
~Michal
|
