[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/7] xen: introduce hardware domain create flag
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Tue, 8 Apr 2025 09:54:39 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RA1/TCjzeqqYD02HZ5fD+5JeIdV1o87pIQuKSETAJT8=; b=L/BjgSd21tcHM0pakzvzJOpcfmEdyzAaeVT1tyIm1gb31eaDNK2m9rSlMqLjl5aWbO8x9IZ8YMeUeazbT6d+rbb0O4k69VRRUaNnrg/mZasqk2JdjUD6ZXFFIRssXimXv7Ym4QDmk92+dAqnNIO2+PQ0Xz0qaB4//FmEYuUxmDkClNx2+GYs/lQfZ36DJFvghR7w0qfpTPsMBoBMUwkehfqhNZwM30ZLELacfun+D+zCccY1QgX43zM8/S8A55uenEzfT8kW/b1IR9BF9YPI3fXNrASrKEXW24PB8jLdVylNJ8XonydpszkHhTXd7bDwI3GQFBCbGbcN42/5po4z+A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=U1ovcY/lpWIf06zV8wmvi1SxK5ScJURHXb7HSqoF7vmP9syDsazRaeyIMZ4PO0OGcE2+V0/rrLjocW8lCXPgx5J9FITf0l/98F3aSn3QInkxtdOXcYlLJvyhEhkFpTfF7+8aJpZwIHWXT4G81QKbV4i916iDPFOUwIe575OFR7d8eDb64IDeCTLIaeJ3wA8QDD/29g/cwZcGHOvJEbSCUmPk89bAMyDSZ5FDCxPHyds9IPeAMX9D/Zuh3Gg7YK8kn9JssXxDhf/j5/S1e0tAM3C0C1deUH9lxG+U/N8Fk5/Ssx7M5OD+Hv/zXfEkehAHboWYgNz4q4XsZgiUgYrq4A==
- Cc: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 08 Apr 2025 13:54:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-04-08 02:37, Jan Beulich wrote:
On 07.04.2025 21:40, Jason Andryuk wrote:
From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
Add and use a new internal create domain flag to specify the hardware
domain. This removes the hardcoding of domid 0 as the hardware domain.
This allows more flexibility with domain creation.
The assignment of d->cdf is moved later so CDF_hardware is added for the
late_hwdom case. Also old_hwdom has the flag removed to reflect the
change.
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
i.e. ...
Thanks.
---
v4:
Move d->cdf assignment later
... despite my earlier concern this movement looks fine to me.
Double checking today, I see that in the failure case, hardware_domain
is restored from old_hwdom. So in that case, CDF_hardware should be
restored:
@@ -986,7 +987,11 @@ struct domain *domain_create(domid_t domid,
d->is_dying = DOMDYING_dead;
if ( hardware_domain == d )
+ {
+ if ( old_hwdom )
+ old_hwdom->cdf |= CDF_hardware;
hardware_domain = old_hwdom;
+ }
atomic_set(&d->refcnt, DOMAIN_DESTROYED);
sched_destroy_domain(d);
I'll see what comments I get on the rest of the series before respinning.
Regards,
Jason
|
