[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/2] xen: debug: gcov: add condition coverage support
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Tue, 8 Apr 2025 15:38:24 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7urgFuUcv9ekelw8kTvRAD/6Qy+f/RzS8svHaMji6CM=; b=lU34akrX/jE4CmSz+uSz6p/F3T/+yw9w4oE0QUwm/DEgtih9qDDrcnDrXsdpA/W5OD7UView80LSXfWtm04Av6dfFgoYYqy2Eh/2H1aEhGlZjSp2QDUzaL6fhP0sAzJ/jdJfpFsUBjsn7J3/iSZpsG/mbZqK5U2tAFWivDnTiWV6YlT8kqjiBDnpW8r6BvIDus3H0NEqcY2vf2B9qkqQUvUqLYssW3A668zZjbbkCCu9Cw2qFwlle3fdxHlHKUD8R9pdCzIGiEsKb5rPEpM5q2Fxxul0Tl/nZ6zu9YBcSmLTaViMne8Ex3P3OVSDQwPqFSDA7c4s0fBBLTFU+5ea8w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IR8wM8Wa87nrD8Ek0gEU8yq3habFvj8rOzQm2Xhv4ht2wH3gBlkF85NNxZuo5Y4+mQfFR8EEebCZyqRsYmBOAQ7ah6UJ4lXp5vkTLkG4tzPk+eNoD9lAEZKjj0yTf4xkeD+uV2atscny8Zh3u8ax+tJl4PGIYHyHr4Ocnjjx43jrLuciSQIzggUfQNsN2dIgDgebpmT/UYrw/Dhv98zykUOmlxxU3Q7gcN9xJKWXhLdcMZacSn0ubVK8JlrLhtQ73yJ+7e0hzjX1tkQv2op7py5z7/EIWJ31kyLLL87WekEWUCytKxsGtCP16CfKFbKCjn6pouqBFagrISfqhKpz/Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 08 Apr 2025 15:38:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbp9yW2b5GBLlgDka417bnQFIpfQ==
- Thread-topic: [PATCH v4 2/2] xen: debug: gcov: add condition coverage support
Hi Jan,
Jan Beulich <jbeulich@xxxxxxxx> writes:
> On 07.04.2025 18:46, Volodymyr Babchuk wrote:
>> --- a/xen/Rules.mk
>> +++ b/xen/Rules.mk
>> @@ -31,6 +31,7 @@ CFLAGS-y :=
>> AFLAGS-y :=
>> nocov-y :=
>> noubsan-y :=
>> +cov-flags-y :=
>
> Personally I would have put this slightly higher up, at least ahead of the two
> no*-y. Thinking of it only now (sorry), also maybe cov-cflags-y might be
> slightly better a name?
Okay, I'll do this in the next version.
>
>> @@ -133,19 +134,18 @@ $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)):
>> CFLAGS-y += -DINIT_SECTIONS
>>
>> non-init-objects = $(filter-out %.init.o, $(obj-y) $(obj-bin-y) $(extra-y))
>>
>> -ifeq ($(CONFIG_COVERAGE),y)
>> ifeq ($(CONFIG_CC_IS_CLANG),y)
>> - COV_FLAGS := -fprofile-instr-generate -fcoverage-mapping
>> + cov-flags-$(CONFIG_COVERAGE) := -fprofile-instr-generate
>> -fcoverage-mapping
>> else
>> - COV_FLAGS := -fprofile-arcs -ftest-coverage
>> + cov-flags-$(CONFIG_COVERAGE) := -fprofile-arcs -ftest-coverage
>> + cov-flags-$(CONFIG_CONDITION_COVERAGE) += -fcondition-coverage
>
> Why's this inside the remaining ifeq(,)? Surely there's at least a chance for
> Clang to also support the option at some point?
Yes, but Clang uses different option: -fcoverage-mcdc. I see no sense in
adding it right now, as Xen does not support version 10 of llvm
profiling format, in which they added MC/DC support.
--
WBR, Volodymyr
|
