[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/16] x86/boot: introduce domid field to struct boot_domain
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alejandro Vallejo <agarciav@xxxxxxx>
- Date: Wed, 9 Apr 2025 11:33:56 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pke6scDrYyqJ8alNKcGehBSfFs5tCsHErWrJaemKv94=; b=s3D9TAOO9xXvlN4bnQccZTmQNSw1b3nB/OYDbVxKdg23VSuRUFEgUDvEmXxVFltHdGoSRHWmxOZO5Ly3+Kp0WxOrbZuVApDs123E9+qiKlUOnDi5fSwxURtetYc2EUj34trIP9PTisb8CkV66nfSrJqTNexPP8UNLctxDqJdCkl7qBg/Pqd/bj1KXdcGoVfN1eYv7GKGqzV7SrqcRqB8cqXd+xW6JQalgQf42lS8uNVG2EVlNyyCkd8rCNqJQxbJVfEb5Stp0bBCxKn2fJdrUwTbtrDfEjq8oWiCq+8D93Ff8vsqxrCViUz8S91Og6A7kXQTkQYN5h8NH2xAZ5XYcw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jv8cnczwM1mTrJylI+9ssJ45qMOGfAJi7+O1Cvju7Qg7GkB8Yb4Y2cUdEci0ACAp9HYKC9h2AS78ZgmuzLCFCrvP83Rovp2jegMHEg+Tjk26Ve7iQH8RC9pXrno5INLeArkhxRMIrUadiqTC0q0gYgW2uwos7FyUCxgClh8BLleKIRqQTBQieeCiwPZ/lE8b71LIGDikOJWUcLdHlPUh1VUKkSWhV9o8b3SHvsYHhdLY01pUV7LqN/wbHBFBPbWvzbYhixCFczaeqv6seDQm1pAZPfhpKCqVV4l/zVhLLxzUZJJCn3I8Fs9swn125N0vNJGJPrdfewVYhb7O9y38yA==
- Cc: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 09 Apr 2025 10:34:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed Apr 9, 2025 at 7:34 AM BST, Jan Beulich wrote:
> On 08.04.2025 18:07, Alejandro Vallejo wrote:
>> @@ -1010,15 +1010,15 @@ static struct domain *__init create_dom0(struct
>> boot_info *bi)
>> dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
>>
>> /* Create initial domain. Not d0 for pvshim. */
>> - domid = get_initial_domain_id();
>> - d = domain_create(domid, &dom0_cfg, pv_shim ? 0 : CDF_privileged);
>> + bd->domid = get_initial_domain_id();
>> + d = domain_create(bd->domid, &dom0_cfg, pv_shim ? 0 : CDF_privileged);
>> if ( IS_ERR(d) )
>> - panic("Error creating d%u: %ld\n", domid, PTR_ERR(d));
>> + panic("Error creating d%u: %ld\n", bd->domid, PTR_ERR(d));
>>
>> init_dom0_cpuid_policy(d);
>>
>> if ( alloc_dom0_vcpu0(d) == NULL )
>> - panic("Error creating d%uv0\n", domid);
>> + panic("Error creating %pd vcpu 0\n", d);
>
> And why exactly is this not %pdv0?
Likely to avoid what looks like a highly cryptic format specifier. But I
agree your option seems nicer.
> That's what would be possible to catch by
> grep-ing for what vsnprintf() would emit for %pv. Preferably with that
> adjusted
> (which can be done while committing):
Yes, please.
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks
>
> Jan
Cheers,
Alejandro
|
