[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/16] x86/boot: introduce boot domain
- To: Jan Beulich <jbeulich@xxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Thu, 10 Apr 2025 16:56:40 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0BkwjW2bc9cIfjxF6BGMr1rI3Ay3yWUXqJSKgGEh344=; b=ijgZ29KVsm7LT2Nc5OquTwK/JA3xDDcZ8h6+24gKwInSSBQmY4pBethgQF0hfS/KCOXjleEhESS6ArWvqlDZt/SduPHnbwluX5sKVV7zLg4hj84zjMRLvKgNijm6kky174YmeEOTF2Lq7FdQ8z/donHxJwqXzBGK9oXYh3NS3MRYix/vjb8bkyfXtwJIwSnG8XWrSncLchgBMY/BSVq8i+umUE4GQSlw6LefKJiDZOC6jMwrrY3P9hxfGSW5+b+q9UtS8e/Q98T5bNV+yBMl+8UGx6LFPeKHP5cqe2dtZ0+FhneHNnp3vuhuiLny0fL/J5tzzGhsBIxNsrldLS0V6g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GV/bS8lpGk/4y5nycwNYhYDOr5/Uy0JzFeD92kgXXjCPzUwHenKdxy+ktJPKzMF7vJLSrgVpG6gZToUD6ia2LcQ4fDMaiidUbDjP/fme3sZ1TIiCK2FAe5SvzPkBsxA1XSspgcg5r4yQgSmIsyHFE7TRV5fQmmp5a5LVkg0OkKKkx4cmWkg6kJXy673YQIRUkUr+XFN+1f2kPQEe6hjqT1zv+nMQ3OOGFKgk787bpSddA5SU0/FkfDrrQSmlaPSsfeLLZxJsGysl9y5gKCT9ROxHp2+NxdozLBjBU8hnjYIThohpvCWH+X8SpfdOdxVJk4wugVdrLz4ecBk16Zze1g==
- Cc: Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Alejandro Vallejo <agarciav@xxxxxxx>
- Delivery-date: Thu, 10 Apr 2025 20:57:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-04-10 11:01, Jan Beulich wrote:
On 10.04.2025 15:09, Daniel P. Smith wrote:
On 4/9/25 02:24, Jan Beulich wrote:
On 08.04.2025 18:07, Alejandro Vallejo wrote:
From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
To begin moving toward allowing the hypervisor to construct more than one
domain at boot, a container is needed for a domain's build information.
Introduce a new header, <xen/asm/bootdomain.h>, that contains the initial
struct boot_domain that encapsulate the build information for a domain.
Add a kernel and ramdisk boot module reference along with a struct domain
reference to the new struct boot_domain. This allows a struct boot_domain
reference to be the only parameter necessary to pass down through the domain
construction call chain.
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
I have to object because the meaningless rename is going cause
significant pain in the rebase of the follow-on series for no improved
code clarity.
Sorry, then an incremental patch undoing the rename that happened (with
appropriate justification) will need proposing - the patch here has gone
in already.
Coming from a Linux background, ramdisk seemed more natural to me. But
looking at hvm_start_info, the fields are called module there. And
since we shouldn't tie this to the Linux naming, the more generic
"module" name seemed fine to me.
Regards,
Jason
|