[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 15/16] x86/hyperlaunch: add max vcpu parsing of hyperlaunch device tree
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alejandro Vallejo <agarciav@xxxxxxx>
- Date: Mon, 14 Apr 2025 20:12:17 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3/dBCQNIEY1Zf5BiUnfHn+bavnDnFJgkzYF7mcfJGSs=; b=plDJ8nfhUsL/c6quk3UlUXt6sKiD49KqUxeOhOexEoL/dPZrdf7S+dZXeFLuk7uMXcM2n7ASJERiJrTiBofDk0QrVj4uC/kkUXhUkZarNXGGSYPPYWvR+sKQpmttC4PNsghhil+Uw6pR90LQ/9sap0aYmZjrLogEeV1NZUtGdWVTTb8UrwO/0xCu7vcjOYg1EDTbTcjiLBODkAJ65BaWxrsK305ANSwmsjwDYjk9sF8DOAzGVEOMJ5sg6kdYIfQdbr1opsm8B5ZRplg7xl29rR/lLzK3hU5t32BDBGX/9FbjC0DGuHK12/K5SHF016QubjfLQB2WWlpm2VHLoIQegw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LxrJnQ4FGTlpR5o25I+oefC87vpXeBdesxfIYfD/kscRV5S+tB5ti0dMV2BieiEYLsRSAeK6X5uhjRG63bMwZrgZaKMePxwE1Iz4C2EeQp/tfMYJh4fi3KvUXlIrWspuhedRMkoC/dd1bEVq1oAsMDgBZbS/cVvcRV6SyfTeWCP6qfq/XyWszIsbIUY2fxng5V1eC6tsCYrIC7CyD/P4yPJ07s4x1gFW6IS/YnHAWBvyIUzvkgds2RK/K5bSIV7S7FZticGmcU8ShnHDmGqsFl0qFOdTuDUk3jWRhX6PDhaUkDmaP9O9nmCjXqsL92s/gDNg8KLKHMHDtLLL6mmDvw==
- Cc: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 14 Apr 2025 19:12:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu Apr 10, 2025 at 1:08 PM BST, Jan Beulich wrote:
> On 08.04.2025 18:07, Alejandro Vallejo wrote:
>> From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
>>
>> Introduce the `cpus` property, named as such for dom0less compatibility, that
>> represents the maximum number of vpcus to allocate for a domain. In the
>> device
>
> Nit: vcpus
Ack, and same below
>
>> --- a/xen/arch/x86/domain-builder/fdt.c
>> +++ b/xen/arch/x86/domain-builder/fdt.c
>> @@ -246,6 +246,17 @@ static int __init process_domain_node(
>> bd->max_pages = PFN_DOWN(kb * SZ_1K);
>> printk(" max memory: %ld kb\n", kb);
>> }
>> + else if ( strncmp(prop_name, "cpus", name_len) == 0 )
>> + {
>> + uint32_t val = UINT_MAX;
>> + if ( fdt_prop_as_u32(prop, &val) != 0 )
>
> And again the same nit.
>
>> + {
>> + printk(" failed processing max_vcpus for domain %s\n",
>> name);
>
> There's no "max_vcpus" being processed here; that purely ...
>
>> + return -EINVAL;
>> + }
>> + bd->max_vcpus = val;
>
> ... the internal name we use for the struct field etc. The user observing the
> message ought to be able to easily associate it back with the DT item.
>
> Jan
Very true. I agree, and will change accordingly.
Cheers,
Alejandro
|
