Re: [PATCH v1 04/14] xen/riscv: introduce init_IRQ()

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 4/10/25 5:25 PM, Jan Beulich wrote:

> On 08.04.2025 17:57, Oleksii Kurochko wrote:
> > --- a/xen/arch/riscv/include/asm/irq.h
> > +++ b/xen/arch/riscv/include/asm/irq.h
> > @@ -3,6 +3,28 @@
> >  #define ASM__RISCV__IRQ_H
> >  
> >  #include <xen/bug.h>
> > +#include <xen/device_tree.h>
> > +
> > +#define NR_IRQS 1024
> > +
> > +/*
> > + * TODO: Should IRQ_TYPE_* be moved to xen/irq.h and wrapped into
> > + * #ifdef CONFIG_HAS_DEVICE_TREE?
> > + */
> >       
> Wouldn't that be more like asm-generic/dt-irq.h (or irq-dt.h)? The field where
> these values are stored is an arch-specific one, after all.
>     
It would be much better. Thanks!

~ Oleksii