[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 03/11] vpci/header: Emulate legacy capability list for dom0


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
  • Date: Wed, 23 Apr 2025 03:31:16 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1BvF9/3y2RiDdh4AnkdVlx5R4oAGyRJDzRMfqWQpQ5M=; b=xI+F8VZFDsp0wLOlnZddyDHHdMWDHwyqxmRg+MM3nKaivtUN3U8Y9Rh08ICAdDU+IsixtZP24A0y5n4cRoGCnlGiSM91aAit0vGp+ezgT09geAcpfiz1qqi6JrMIBKsdk/nD081b5aI/2Ln30tKIJYJsm+RfiS2O+b3aaNkxcFu5WIXJ5G2SBEd3/WU0Nx7YCyAyz4zN+yip/Nss656LMWSkDk3r36uD2BNAK6k8snhJYbWETEQnz+b9FfqniuimGd7JdtoETy9DXIP/qmCR2JTHyUCZDbLGMgFVpeB4Fq4JBSvTYpCTwYOVMlY7au/vHIa2UrAtYVZoyag3ERBx+g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rruxgc2iVLNztS+GUgK60lmRL6HU3RFMUwiyozK4L9+KnU2GPYld3qaDRsL2VsVMDskAHfIXDINgOv3RG9dnz7luY9xi9Muw20e/nLGFHaP7cokeLCXRcjEM4jhZurxY61NBnG+QceXY+w0/aevxKsCENzKFAmAxyvg69hf7QS0VjeWqGcUcMOJAvFq0aCS1jP6qiwk4OtQiO5nfgiWC3c6QVHKoPKiSKX9tzy2C0r0Kqt2K/SdTt0hJ+vgfgSHydMMXswfAAe66eUTRF79zdh8JYHj3hrCCp5W0uTLPkH290l+2WBDd7WcKGWqJkd2t3dvj7CLYy8avLLeqU2WGhw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
  • Delivery-date: Wed, 23 Apr 2025 03:31:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHbsoVY0As/JNC0IkWc2g8aH+9wh7Ov2pQAgAFGpwA=
  • Thread-topic: [PATCH v3 03/11] vpci/header: Emulate legacy capability list for dom0

On 2025/4/23 00:01, Jan Beulich wrote:
> On 21.04.2025 08:18, Jiqian Chen wrote:
>> @@ -759,10 +759,11 @@ static int vpci_init_capability_list(struct pci_dev 
>> *pdev)
>>              PCI_CAP_ID_MSI,
>>              PCI_CAP_ID_MSIX,
>>          };
>> +        const unsigned int *caps = is_hwdom ? NULL : supported_caps;
>> +        const unsigned int n = is_hwdom ? 0 : ARRAY_SIZE(supported_caps);
>>  
>>          next = pci_find_next_cap_ttl(pdev->sbdf, PCI_CAPABILITY_LIST,
>> -                                     supported_caps,
>> -                                     ARRAY_SIZE(supported_caps), &ttl);
>> +                                     caps, n, &ttl);
> 
> As per the v3 adjustment to patch 02, you can pass supported_caps here in
> all cases. Only n needs to be zero for the hwdom case.
Oh, right. I will change in next version.

> 
> Jan

-- 
Best regards,
Jiqian Chen.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.