[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] xen/arm: fix math in add_hwdom_free_regions
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Thu, 8 May 2025 06:30:43 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0MXaUm47bYx3+3m1ziqPITat1wED23CHBObq9T6YqLA=; b=ajuv4oaYYEo5G5QanV1ahoXsN9JSSqYTsKQmTuy6+6wNyQ24IfUuYKJ8cCPXEeJemj9hYfzqueF6E9Q0yBh7edObfR20c8Sm/8ob6tTgwAH/WfrsvixOTdsEaKc3xFC5yYQacVOcnPzKja4RXDSYgknnsgiqfQNxlmwTyRnvggBw/t2/+FVNkaS1+On1MZtsSdGZtm/uwwwSDLDOvR/OK1xpjNym2SkxMT5jYonkFoSPwmaGnwTrzKzPMrjqROIbdrQTwMxPnJu+1G6EC2XUzRZkDKGMKf0qTB6H6dspm3X03ac9qT+3VNd5NeuB/JoX/KPLrZ0BpgXDydrATASu3w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r4vfXdsQIfxuq/rshKULyinpA/oo2BGojJvHy+dj2ZRXwrqAoaHrpoYTCSM8Kw+fZXFFr5NRVut42mFTqkI7SSbwzCbzXLHHXkYACwJNYQuHD7ZHSV+QcNrg++ZBRTRXAWks4Zs0oCIqWu61XClJZ2GFZ8b+T37SPaiYA8tyc0VUU90551vfHzEY5E+MPiT8OeaYhqlCDv11nHcAtc8pTsQCwWXFrVW+VMPfj4FrRd4HLlqSAvG534KXSDQ2K3/7gNqZas+CCcyUR8DPWISdPzIF8egZIHyh2QLfv9pRUL2ji7V9wlpsj48u97f0t6xEMqjpNdgVWR+h5OIGBx8vdA==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 08 May 2025 10:30:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 5/8/25 02:56, Orzel, Michal wrote:
> On 05/05/2025 09:52, Orzel, Michal wrote:
>>
>>
>> On 05/05/2025 04:56, Stewart Hildebrand wrote:
>>> Erroneous logic was duplicated from add_ext_regions() into
>>> add_hwdom_free_regions(). Frame numbers are converted to addresses, but
>>> the end address (e) is rounded down to page size alignment. The logic to
>>> calculate the size assumes e points to the last address, not page,
>>> effectively leading to the region size being erroneously calculated to
>>> be 2M smaller than the actual size of the region.
>>>
>>> Fix by adding 1 to the frame number before converting back to address.
>>>
>>> Fixes: 02975cc38389 ("xen/arm: permit non direct-mapped Dom0 construction")
>>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
>> Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> I wanted to commit your fixes but rebase is required after recent dom0less
> code
> movement. Please do.
Yes, I have already rebased locally. I'll send later today. Is it okay
to keep your A-b tag?
|
