[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v21 1/2] arm/vpci: mask off upper bits in vPCI read mmio handler
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Thu, 8 May 2025 06:46:06 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pYTYGm7TjGTCoufqxQwgoqyUeE4OFG8EYrCyN+3Hwuk=; b=BUFaZEXR1gSG1MUw/8YnfoBJFGN9usaanAjoIsXIyQ+xeIQ3fJNQoS/+EmWFwiQvpX4fdpWSSCrwKGVxrwU0a3rVBRUKCtCiHbYYZ2eCbrxg1w+PILwi4DgtkT46ev5TQTp/6Clgpkvy4n5npNDOpvFI+08TGRnBSiAi2r2cs5rD4/fTrFCr322BuIyFZKBCPPV48U7XC3J/A2e6RdRVOIYnJ8m7N41dzsrPooGP4Gk6eIcHg2EBVUAOp0k2PLK7WXgFanf0SGj8sFIDU0q9rCJMj61Khb5MLpEhIwmZ6d+0pEfQAw1elFd2bjSiF4gM1LmX7iYfyyXlcqP0S6hmeg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r86qIHyF+WcwebDZD7IK01fIMh4zZQ12C67Z5w9CFwo5BOa2kcIdsGAOOPSdh/cXHq9jQccS3dartLeycQbD3eG0rX/ECU+eYvnVAffXDoWlHQqI1v+RwhFaj6jQ71nG7I/ApKT9hqUnf6fWNKmhdLCakh1JJ1R+n2Ru0xjFK0vwyytRgk4J/FB2e+eTDUZ6jArLXrk6wSz9QwXI45d0y5QVp4jFqPuSknknmAapt9l/ld5sMWD7D9C2IvdL2Of/muGbbuV+TMaoPTLXuoxUaeDBsngUK9ec297yA+zeKveOmWRDVog3yeQ1rYBepBpglGjShBPw92u/29rSQVRIqQ==
- Cc: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 08 May 2025 10:46:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Arm, we expect read handlers to have the bits above the access size
zeroed. vPCI read handlers may return all 1s. Mask off the bits above
the access size.
Fixes: 9a5e22b64266 ("xen/arm: check read handler behavior")
Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
---
xen/arch/arm/vpci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
index b63a356bb4a8..3a3ff5d0812c 100644
--- a/xen/arch/arm/vpci.c
+++ b/xen/arch/arm/vpci.c
@@ -37,7 +37,7 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
1U << info->dabt.size, &data) )
{
- *r = data;
+ *r = data & invalid;
return 1;
}
--
2.49.0
|
