[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/6] xen/arm: fix math in add_ext_regions
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Thu, 8 May 2025 09:20:30 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ebr89cmmGKzjaVd2xUcU9bNIqcI96l1VlD/ym5sCsJw=; b=R6GDDdgUUQZZnJyBnuYYj7av3BmETVPnV0mdqXvU7my/k0IEuBAt0TE8wyJ+eGWrnqTliySyamh7UgzBzEyfHHGI6qe09xkp0wwH1l8ZySbIatko3AgEC2rJStPugDVniZummKDmBpE7/lqiMMfiA4kE64YM+E0fZkaP5M813huCw44W4+G05/R8gonbVkQlNLZveKP0pmGEuRkwyDfnpF3CGktzNIDB3m519gqc2u+rDi8Uiy1B5L2OqxCD+ZAT6p8SHybNV7VfKDwLNp1/UwkhWAK8htjACOB7hGNDQQG5HQKxfyfxGbG8TbK8vwY1eQ8ZO08ywdN+O2v+rcgRdA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AKzW80P4B1t+/bw5zbhVe8ZOQ5nPsTCRR4KxnZx1Q4L4Zo9EUTarEp6IZtkrUAD16lyD/OY6cUwCRuovFtMTZZAXLHIThsLrrWGrVDnIgiYRHulA3f8rETcueD4BXgV6nPsmJs4qu3r6+fNAttWIS6AncnH8i/A/ZS74mlRd67K+I25CfWkJCWnuIhgXea8SfnAVPKrxFAYUhVf1CG7e3RWEv9/Ln7l1a4oCWRCIMdoEGgupVKRi0qJX+2VQ4h7Mi4/z/9+wMJH7/2eASeF52b4FcYf/d4jA9/ITLV9Szw5et62waVOHx0wvI55TNptuQaVzoMEHjalhpeG/CmmeSw==
- Cc: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- Delivery-date: Thu, 08 May 2025 13:21:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
In commit f37a59813979, the arguments to add_ext_regions() were switched
from addresses to frame numbers. add_ext_regions() converts the frame
numbers back to addresses, but the end address (e) is rounded down to
page size alignment. The logic to calculate the size assumes e points to
the last address, not page, effectively leading to the region size being
erroneously calculated to be 2M smaller than the actual size of the
region.
Fix by adding 1 to the frame number before converting back to address.
Fixes: f37a59813979 ("xen/arm: domain_build: Track unallocated pages using the
frame number")
Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
---
v1->v2:
* add Michal's A-b
---
xen/arch/arm/domain_build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index df29619c4007..2f2b021dec3e 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -761,7 +761,7 @@ int __init add_ext_regions(unsigned long s_gfn, unsigned
long e_gfn,
struct membanks *ext_regions = data;
paddr_t start, size;
paddr_t s = pfn_to_paddr(s_gfn);
- paddr_t e = pfn_to_paddr(e_gfn);
+ paddr_t e = pfn_to_paddr(e_gfn + 1) - 1;
if ( ext_regions->nr_banks >= ext_regions->max_banks )
return 0;
--
2.49.0
|
