[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PING MISRA] Re: [PATCH v5 2/2] x86/vmx: remove __vmread()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Fri, 16 May 2025 14:53:03 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1747399983; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=FleCSofpFpSueE1Xkc0dKlgxuyo7SvDJ1/JJXedVDA8=; b=po0sPP6rI6PXScujQoqUHYfZenOpu3oR+1DKg0gYGERljSC797dEI9QfOxrtAOGjZC48 oJtF+BhT2HSozxOWB/02303UqH3C3qRJWSrxOA8d0Qnzxa0ezm9BuaGJArGU8XuxYZEw/ UtrpukM9c6sAAsUGX3UJO3Ch3O2McBi5/1o6V3QE9ByXIN2qMlfa95GHuDsQxUsu2dpjd B7sX1o5DQ+P9bvvfFUCBMOsjFybP3y6M5vf+s/AkP3JVQA8WgwaWqOFJ+rO5OQre2rQi2 j1IkMu686Yg1baP4keBDxVKtwuVNR6uzDJRR/bsD0iiaEbgvoDgoZ/MHu8vrMwtD6xhv3 VyylkV5oxv1/I8IHWAiPPe3PtIHqPDNAtKw2fltrW6XDo3qeH3R6hltrDdCt9Hvqq2A05 vefVx16T8aajPDyxXhAgXaTChwpY/WVeZFfoQX5U780p7U19KToNhuKV68xJqq9ffaXn3 2HAfqY8ZtTUpKknABkZemo2u7bb0pnPxNxcmcjgREijV329xIAxgqHjX3EVDkRbJG8BeC GDXUPn6QX3rJV28qI+/1Eik+Wk1q1eYlcPGwbygrLGdrS0R0SlBEzrRuGbD58ZtOpEvXC b9dX5kEN2tmKs8LkOehtMEb+rqv2SvwoLb8qzg3D//V0dPEPvJr9DOzSoiiHZSc=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1747399983; b=pVVj/R/SsydW29TmR+Ty4FdZd3Dr8D5J87Z3I2dCZdwlnK2B+LkfktWrAEnkohyorVyP Xtsy0YevNxj1pWU2NEHgvnhx4ff1z2bE9tSXgBD5wtelf1zt50S9DrqhkbPPEzpqv+TAl 7jdCha9qQnxXhiU6K4egKPdqvdTgKIPDmCMiJRjg7cyPA7nV6dNwoe9C4zE1VdkiEDmgP k4Pa6W1tOsC2X9jeEZGlDvcDYw61/dnC/LuH0l6XnGezOr+kgPu5+bjtUbCBXn1PAi4qj 12PuJSAWpnG8vjeREtsvOtewA9h5+SzYJj8pvBmYfRLTWp02m95PQHWoaTafVin80rTch YB71xe8mO8r8qK130V7mX2wRcfHeTU0FYM1dWQ4UQGP1zenQqi2eakIm6y3nmlACQfNQJ eoASky968pxvrgb+4mUe/MMKbEg20r9w/vTAIzOV9neeqgECRTzsiZga7X2gXB9fPOFNp Hb9tSW/gmfCBQmAz9eSGqtjfUcR60duv99U76h7NdJjJ/QgFTdcGEItQsU+3ITpKfyYo0 ke6Phq7AK24csuspal1eQbaJ2V0+ZM6wR6eZHkyFwSIL9Uo9RJxYsUutacxkRXE1WzQGv 0Ev1sB9qmbP98d/NcnEt1a4tZ/0rh857g679IoCRk55AbXOC/QQugXRWwRd1HvI=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: dmkhn@xxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, jbeulich@xxxxxxxx, roger.pau@xxxxxxxxxx, consulting@xxxxxxxxxxx, dmukhin@xxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Fri, 16 May 2025 12:53:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-05-16 14:45, Andrew Cooper wrote:
Hello,
This is adjusting some MISRA configuration. I'm reasonably sure the
change is fine as we're simply removing the referenced helper, but can
we get a second opinion from anyone who knows what
function-macro-properties.json is supposed to be doing?
Thanks,
~Andrew
Hi Andrew,
sorry, it slipped under other emails. The change is ok.
On 13/05/2025 6:28 am, dmkhn@xxxxxxxxx wrote:
From: Denis Mukhin <dmukhin@xxxxxxxx>
Remove __vmread() and adjust ECLAIR configuration to account for the
change.
Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
docs/misra/function-macro-properties.json | 9 ---------
xen/arch/x86/include/asm/hvm/vmx/vmx.h | 5 -----
2 files changed, 14 deletions(-)
diff --git a/docs/misra/function-macro-properties.json
b/docs/misra/function-macro-properties.json
index 74058297b5..59ba63626e 100644
--- a/docs/misra/function-macro-properties.json
+++ b/docs/misra/function-macro-properties.json
@@ -152,15 +152,6 @@
"taken": ""
}
},
- {
- "type": "function",
- "value": "^__vmread.*$",
- "properties":{
- "pointee_write": "2=always",
- "pointee_read": "2=never",
- "taken": ""
- }
- },
{
"type": "function",
"value": "^hvm_pci_decode_addr.*$",
diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h
b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
index d85b52b9d5..299e2eff6b 100644
--- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h
+++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
@@ -336,11 +336,6 @@ static always_inline unsigned long
vmread(unsigned long field)
return value;
}
-static always_inline void __vmread(unsigned long field, unsigned long
*value)
-{
- *value = vmread(field);
-}
-
static always_inline void __vmwrite(unsigned long field, unsigned
long value)
{
asm goto ( "vmwrite %[value], %[field]\n\t"
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
