Re: [PATCH v2 09/22] xen/lib: add implementation of SHA-1

[Sergii Dmytruk <sergii.dmytruk@xxxxxxxxx>]

On Sun, May 18, 2025 at 10:34:07AM +0200, Jan Beulich wrote:
> On 17.05.2025 20:17, Sergii Dmytruk wrote:
> > On Wed, May 14, 2025 at 05:58:59PM +0100, Andrew Cooper wrote:
> >> Please crib from sha2.h as much as you can.  Use xen/types.h, drop the
> >> double underscore in the guard, and provide a link to the spec.
> >
> > Until yesterday CODING_STYLE instructed to have 2 underscores, so I
> > thought sha2.h is outdated.  I'll switch to <xen/types.h>, although it's
> > overkill there and only grows header dependency tree (it also brings
> > extra symbols thus hiding missing includes elsewhere).
>
> If xen/stdint.h is sifficient here, I'm pretty sure Andrew would be okay
> with its use instead of xen/types.h.
>
> Jan

Oh, there is size_t, so <xen/types.h> is actually appropriate.

Thanks