Re: [PATCH v2 2/5] livepatch: Embed public key in Xen

[Jan Beulich <jbeulich@xxxxxxxx>]

On 15.05.2025 11:38, Ross Lagerwall wrote:
> --- a/xen/crypto/Makefile
> +++ b/xen/crypto/Makefile
> @@ -1,2 +1,15 @@
>  obj-y += rijndael.o
>  obj-y += vmac.o
> +
> +obj-$(CONFIG_PAYLOAD_VERIFY) += builtin_payload_key.o

For new files please prefer dashes over underscores in their names.

> +ifeq ($(CONFIG_PAYLOAD_VERIFY),y)

This isn't needed, is it?

> +key_path := $(objtree)/$(patsubst "%",%,$(CONFIG_PAYLOAD_VERIFY_KEY))

Since they can be used there, dashes imo also want preferring for new
make variables (unless they need exporting to the shell).

> @@ -143,6 +144,11 @@ struct payload;
>  int revert_payload(struct payload *data);
>  void revert_payload_tail(struct payload *data);
>  
> +#ifdef CONFIG_PAYLOAD_VERIFY
> +/* The public key data contained with Xen used to verify payload signatures. 
> */
> +extern const uint8_t __initconst xen_livepatch_key_data[];

Nit: Section placement annotations are generally meaningless on declarations,
and hence want omitting from there.

Jan