[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] arm/vgic-v3: Fix write_ignore_64's check in __vgic_v3_rdistr_rd_mmio_write()
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>
- Date: Tue, 20 May 2025 13:47:53 +0000
- Accept-language: en-US, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gv320cKpVHu9ZqS2VbG6u2IhE8QZWqYFIV6gaZm8cCY=; b=WuoStJoNIG5GrikCy3wHaErPATK8fSFhlvRuKWs184Y6L5+x76bB8KHlFaz79xRKoUs1VMKIWBNOaDzFm/wK1QrcgjjXCSPf0aGc2laW0TEOVASW/gNNcJUSyUDtc2KAM90pufRJDy9v7EES4ZgrtA6d4iiYOxhQ6nP3tq09I/aV3Me0db3l21pkUoJ/T4DKtq4kkEC25GfPx3l55kEStOkbx+60iegM0Vh/rJVyz2jRx3WYZ+ctYrriTLUdbBU1Nyt8g9FfR89eXpOPixtsAUbvOnqLfxnI7m0oawYwJaejsMqazm+DoKb1Qioas0aRQe926mafGennOr62CS8znw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XyCIZfCnQtoQUegrDrkQZrbhay7mQFr4R8mkaCQhkd6pZlwo7oILRu7cBzh5T1J774XYg6Gcxo3CwypCt+fhjjqbW1VPrdb1iXSk+cTkeAEwxsh3W8PQSxqKK0A4cWayFOMJ+p1IowN6fKLvbJBfCljHO/nno5aYSZMqZM1fvcShLsu44qMrDj5ZJtBJVLbitPbWQEO+mvbKzE08yjbv25Flr1nwkexbzQqqUlNLx/Q62fKUEW9JWRu8He0cZk2/hKf/m/yjlQ/MbvEfcQGNPSrultsf/89il1Vd+YX+jC6AehyJfPt3f8NpXDFzRXQ9qXNnADZkZWA1/gqdOrkSrw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 20 May 2025 13:48:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbyY3It6QrN0GxI0mChLdwI1GDxA==
- Thread-topic: [PATCH] arm/vgic-v3: Fix write_ignore_64's check in __vgic_v3_rdistr_rd_mmio_write()
An attempt to write access the register (i.e. GICR_PROPBASER, GICR_PENDBASER)
which should be ignored (i.e. no virtual ITS present) causes the data about
due to incorrect check at the write_ignore_64 label. The check should be
inverted.
Fixes: c4d6bbdc12e5 ("xen/arm: vgic-v3: Support 32-bit access for 64-bit
registers")
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
---
xen/arch/arm/vgic-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 2eaa48fadb..b366b046a2 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -649,7 +649,7 @@ bad_width:
return 0;
write_ignore_64:
- if ( vgic_reg64_check_access(dabt) ) goto bad_width;
+ if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
return 1;
write_ignore_32:
--
2.34.1
|
