Re: [PATCH v2 10/16] xen/riscv: imsic_init() implementation

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 5/19/25 8:33 PM, Jan Beulich wrote:

> On 19.05.2025 17:26, Oleksii Kurochko wrote:
> > On 5/15/25 10:42 AM, Jan Beulich wrote:
> > > > +                   node->name, imsic_cfg.msi[cpuid].base_addr + reloff);
> > > > +            imsic_cfg.msi[cpuid].offset = 0;
> > > > +            imsic_cfg.msi[cpuid].base_addr = 0;
> > > > +            continue;
> > > > +        }
> > > > +
> > > > +        bitmap_set(imsic_cfg.mmios[index].cpus, cpuid, 1);
> > > >           
> > > Depending on clarification on the number space used, this may want to be
> > > cpumask_set_cpu() instead. Else I think this is simply __set_bit().
> > >         
> > cpumask_set_cpu() requires cpumask_t which uses static definition but we are
> > using dynamic allocation.
> >       
> But you're aware of cpumask_var_t (and respective allocation functions)?
>     
Now yes, thanks.

~ Oleksii