[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 5/6] arm/mpu: Introduce utility functions for the pr_t type
- To: "Orzel, Michal" <Michal.Orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 22 May 2025 09:56:12 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HX0ICNMa/FDROzjfi5n4RwjMAAbwXLqOf710uP5MNXw=; b=CWr2mug8LToXeXRkLt3Uoy923ap67BX8xrETFUbSfEkJaan8rSc9FgXOMalAaa5IbadClmUdT7R4yEsD8lxRDL9eNRk9dNgIiQU0LhA5N6IehmqI6AvbUqx7m6MCNaLwjiPhYpMayfOcJX2ar8Os3qmBUEXZhAg8qjGXM+R5W+83y0DaVmhxszYVyhFww4yvw41Oxbg9A92JGscijLFKp094n0XQWS4IbwV0xOHwtmHqYeNZNa4uYEGBvBRDX2DjbEaU/5gVobTJntkxq5WgPN9dkYY1uYIqhX3hGsO5stNVrNmIq6OKxz7nlPk/ICDBn7KLp1RXBYVeXxgxQDjrGg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HX0ICNMa/FDROzjfi5n4RwjMAAbwXLqOf710uP5MNXw=; b=Zae72FQF7/o3pS+Dy33/VGetG+QKwK017/SE+LIEStXf1TcWtTMIAjBNjghdpxYB7+h1DUgTQ4KUeCNU1shXWNLuIE4+ZfIgGubXgETxHCEaJXaeOKSpiA4fz/AHGOVLT6EUFkd0bevsbi4++C2WA3z8s9VNnjTnuw+In+rPAbLxPm+u/6BWxsBA8WeeoL9E8uGhfXlcfRdU9X2wCq2Y/oLxEdkt4yOmmsrrGPR3gTcqXb16JMffrja+u4OnWFZs+sYcrl9PknouQfvuwWepbkcbRWl/SrGuwyQEjqAzzfl549aGwt8BZcHf+qYgaj4erzBn1tpvO/h4HF8T4B7d0w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=It9SQYTVbtPNz4JpCDorbMPX1eF2R5JBoQTQBokjsVOJ0rtiVDXADFkiQinS98oR6WW9kBOS4PfIMonfxqOUvv7D/5XMFCuc2r5lRw7VeKcPkBeRZjMtXzMZCg/35mxstdA5KZ6z+qq6lDX5apYirdnT/WGuJco6/VQa/+EvKWEUN8UACi0CJE0kDGHQO4BaHcz7Qw7BkB6uaMBWkZ6PhzLncF/XSHIlwD0/TFHHjxYYn2HA34OGm2o+yclOmpzc7ZrLFFD7QAgdQXGsoQrwnDD0E4VkggcZY4WCaNGF36lAhP/TD1f1wDrP0cbovUPTYacceGzjW3ur8KBlxh2Ecg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O6w3ea3NxzeLt8w3tqvtfAtKd9F+J0RgFyiqVOiMaaYDgzMCmWj6YsjSb9KiA8P/nhzwPa53qbb10QwSLzxKLCHq7Cs3KgO/nWMXmji0DU0zeFg3ltTzaqmpvP7yNMk+w/Auq1bOJ86nnJEwODv0ZQruQmZzuZ8AdErxl97lrgTqU6jEClL8WMtXhaXQ/sqgTxyqikOX+KcvdPsN0LSjRfGG4LLrKWzIEEZYwUK6yRfAG/iwGZpU8O+Q5q4BvccwbGmpcmlOf6C3ZvlqER7m0ujXpIa2H7BrSLUMUm1yNQ3OpxX1geHF+tQK2cH5TuwfqKHJFS0G7pMnzvKluIO18Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 22 May 2025 09:57:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHbw+N8axomw5+oq0q6+Td9FW5OAbPeZN4AgAAStgA=
- Thread-topic: [PATCH v5 5/6] arm/mpu: Introduce utility functions for the pr_t type
Hi Michal,
>> +
>> +/*
>> + * Set limit address of MPU protection region.
>> + *
>> + * @pr: pointer to the protection region structure.
>> + * @limit: exclusive address as limit of the protection region.
>> + */
>> +static inline void pr_set_limit(pr_t *pr, paddr_t limit)
>> +{
>> + pr->prlar.reg.limit = (((limit - 1) & ~MPU_REGION_RES0)
> Might be worth adding a comment that PRLAR expects inclusive limit hence
> (limit -1).
You mean on top of the assignment? I’ve probably misunderstood you comment in
the past version
and thought that the @limit description was enough, I’m ok to add also this
comment.
I’ll fix your other findings.
Cheers,
Luca
|
