[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v3 11/13] KVM: selftests: Assert that eventfd() succeeds in Xen shinfo test



Assert that eventfd() succeeds in the Xen shinfo test instead of skipping
the associated testcase.  While eventfd() is outside the scope of KVM, KVM
unconditionally selects EVENTFD, i.e. the syscall should always succeed.

Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
---
 tools/testing/selftests/kvm/x86/xen_shinfo_test.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/tools/testing/selftests/kvm/x86/xen_shinfo_test.c 
b/tools/testing/selftests/kvm/x86/xen_shinfo_test.c
index 287829f850f7..34d180cf4eed 100644
--- a/tools/testing/selftests/kvm/x86/xen_shinfo_test.c
+++ b/tools/testing/selftests/kvm/x86/xen_shinfo_test.c
@@ -548,14 +548,11 @@ int main(int argc, char *argv[])
 
        if (do_eventfd_tests) {
                irq_fd[0] = eventfd(0, 0);
+               TEST_ASSERT(irq_fd[0] >= 0, __KVM_SYSCALL_ERROR("eventfd()", 
irq_fd[0]));
+
                irq_fd[1] = eventfd(0, 0);
+               TEST_ASSERT(irq_fd[1] >= 0, __KVM_SYSCALL_ERROR("eventfd()", 
irq_fd[1]));
 
-               /* Unexpected, but not a KVM failure */
-               if (irq_fd[0] == -1 || irq_fd[1] == -1)
-                       do_evtchn_tests = do_eventfd_tests = false;
-       }
-
-       if (do_eventfd_tests) {
                irq_routes.info.nr = 2;
 
                irq_routes.entries[0].gsi = 32;
-- 
2.49.0.1151.ga128411c76-goog




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.