[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/x86: Remove is_periodic_irq() prototype


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Tue, 27 May 2025 18:54:44 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wAm369P1Yl+9qv/sZTUPGuqQePdOUbvJfCryarsCOE4=; b=aRFn+446NHSyDZfqsUpECa577AjvPXH67Mwr/uA/v3T4o5QFHoSvvO8oo9DEqPuUP8ObtJ2WRIr5ZVpwwrK+yM0uTVSpjwIZibMjDnkPFyaLcpmcTEsSHb12nG2kVmVbOHYGNwe+OntcnrF0cjtkCXOnMvmQSpLrMi7C43RvmURCgFH4h1vFYWt9kaUKWwaRZ7b4fNvkSktE9Cl2zARMoK/MyHh0MaSmDAAA9nayvEMyB8h0d+Eaji4T3MIEqespy3cpR5wRNSAEnNrLpz5+dFSS6xJv/wO0zf2a6zUos0028RLbZ8fwMcMtQG9BfPNj4DxwCIi4/veDoQLExGPl3Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=d60D5/QZRAEgRXphK4Rdq6ous9PPg+SJczJghFfA9yxymF3lauObIATyUsTLsAnqKiigYUlvKbOW4BCAqMZvKTWTun+PZGcu+rntIK0MEuY4OConIkVYaKXDTbBdZjlA/93KjL2wcTXN9ZLQKjKOupotu2McS58e8tKjhAWyvg27UxLwa+GuddnrWcLaIWYZL8A9ITZZBn6XcFPToSEkj5TlVIMkRfTk6fQOQbY2OKPAeAre82fnziDJWOH0oTsAEOddktx5wr3pVTB1NODH9QhJzfW585zl2FFCALwIvJBOr+8lfj3BLuCAfy0p1kJzhv9Hf4WIkeG+IpDzzk7pQQ==
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 27 May 2025 22:55:00 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-05-27 18:39, Andrew Cooper wrote:
On 27/05/2025 11:37 pm, Jason Andryuk wrote:
is_periodic_irq() was removed in the Fixes commit, but the prototype
remained.  Drop it now.

Fixes: ddc35d1cc994 ("[HVM] Enable more than one platform timer...")
Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks!

---
The full Fixes line is:
Fixes: ddc35d1cc994 ("[HVM] Enable more than one platform timer (PIT/RTC/HPET) 
programmed as periodic timer and adds them to abstract layer, which keeps track of 
pending_intr_nr to avoid time interrupt lost and sync'ed timer with TSC.")

Yeah, the older commit messages weren't as well structured as we insist
on them being these days.

How did you find this?  inspection, or a tool?

grep after looking at your vpic.h patch :)

Regards,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.