[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 3/6] arm/mpu: Provide and populate MPU C data structures
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 29 May 2025 09:52:09 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=xen.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A4Wqg/9BaQM7DwHOXybQRwdg93j8pb3GCJXjudbx8j8=; b=Bf5rVk5wxT+ZX3k5K47bw5S14DR7jB/dANA7NByLbnxxc7B5it5LeP+tVCtjDBjKYCmjOgbcUInCBeXjTmgcxf0zlk9dYfjYjm4vVKkAHKnwdecxgAr2ppYmHdyVMvEO8+9p9ineIH15HnNWAgLMICX9WaZgavEP58c827yFYszbG0/P6NNrfVK2csys98xVaHE4ikI5mAmJBoS8WqiVFIjPNZVucOIjFst8Kv4ENPALXwexdg2nvW0r9oRCR/jVMhRH9beRQIzF7UzWGC/Di9TA9nEWhru35qkLTsgZTmSzA6NuEFZuqNJ039uv+3qlW1Qk+2sI3LFTj1dqFX/04g==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A4Wqg/9BaQM7DwHOXybQRwdg93j8pb3GCJXjudbx8j8=; b=TunxOZxe5w8oXKYwyk/bTWuC15BekOYd4z/IdtDFGzsBt7e49T4v0UwCS6OhjM+9ZINjxg3Wvazu5Au29VPtLnpkIUiCL94LUDwSnKIhYo/SjPU757XxuwHrx4Ci+360fvbQLSKll0S7+eg2bDff5OgSENZBNauiXzCAb5xsU+cwJwFPXt8BBzBkpcHDcia96EhgCGnhO79fMwpkRU8CKF4VkwqI0JmFdFc2C7wNZI+75LNYuEzHKxEfW0CDhKG31QWnQAUh48zdocKonoq29Etzq09YtR0BKzF62B7P6TMc1j4kf7X+BAHyt0Jc18FcLPk7T9K8Z8f6MaM7GUd1HQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=phW8nnMLwwmmnsKZdWj5ZZy6SC5/ZciAQOwVEupb3do/pBlm8twgxJTBgsQ5siABaMhqRfC5F2MuRxOixlmIh3Ba54FbOIroxIgvSk1+Ixli88eUDXmZSj5k7DuMDtGpvkY0DWbTPgVYm5kkBRbPEUytzY4c5fsl0AegeIC1HAmurBw7Z443/AmwK8qQ/mt96CxGVhuH3KNXGb+X3LLoIS4Uv2bhXkxv7f2auGXy6oJWqPDCuP46NvtBdl3mUA2yd8DIADPrDD6y6lsj5+yk9hz5EadN7XOXndczIrhDMYpmISWxqTUAYdvjL9E/6sXgcOGBIuAHX1w8Tp0SZ4HhxA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DKvB2UfDMjycxSEDZst/oPdo9BejQ7hv+Ar8XtlEUIAhwGG7118not03oVLjphoOouVJZCm4N4Bp2dsbpvbgxvxVCNw2fsubbZu5IjMMDOhdvtxy9E5MMLFuu/C9tYL+ROgfJXsfZa/Wp1PyWQDajbf5KyykOlFgdVQ+0hHvh6rt8H15ySKvegnCyK1JFgnbbR4Y1RwW+Ryu+Kbh+D4Ll9Ggamv9dNTZ8abimxq4TM2ofEcuWlSDKEsttJYQUXVXTx9858Tpenoke43wNU979LGcYbuGuNnp50HPFB9PKTVbWDoNwwhphP/I6NGlJAOtQ6oF5qCD4JhI3jS2KsRIHw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 29 May 2025 09:52:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHby6+RibcK1nTrN0C974oHFjnUh7PpZYGAgAABq4A=
- Thread-topic: [PATCH v6 3/6] arm/mpu: Provide and populate MPU C data structures
Hi Julien,
> On 29 May 2025, at 10:45, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Luca,
>
> On 23/05/2025 07:54, Luca Fancellu wrote:
>> /*
>> * Macro to prepare and set a EL2 MPU memory region.
>> * We will also create an according MPU memory region entry, which
>> @@ -59,6 +79,24 @@
>> dsb sy
>> isb
>> + /* Load pair into xen_mpumap and invalidate cache */
>
> AFAICT, you don't invalidate the cache below. What did I miss?
oh right I forgot to update this comment, Should I respin the serie or could it
be addressed
on commit?
I would amend the comment as:
/* Load pair into xen_mpumap */
Cheers,
Luca
|
