[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: fix build with HAS_PCI
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Tue, 10 Jun 2025 10:19:35 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sdhbKJJ0w+OYpWulNbyiqaGhEat653rrXsmKv12Sbt0=; b=RKC/8Nh2Tr4Ti78aYcrYsqD1Pe5sMO4QPqzu9A1OYbOWC6ispNDzyVqzoxxajL3cJc+elx6JqeNX9wVPkIANrWzoF0ecU6k2MPs7ULOYfvk7fMubTeffwGV7kMIvUOMzDFC4AvURHmJbk+eOPSZvxV+KPskqXYU5crB4kjghGjXZ31iZjPaGnH6D2cdx6iXaO3l40Dm/zb805djcFyfaMc3/8ThojzHJxh8B6hYndbodDp2jtM/9vgavys5TUsZP2bqHUa07nXSrQ1zihKAbjjt+ltzVx30i1ohvuYnhCarFpO4eAOKB7sUoVcA/viMIJI/D8Qg2lr5ptuO33FPedw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zKbDpDFpa0LB3lpXOQoGv2ssPFknT1IepbJdN9V8TjrjT6t9MBiErdVe/qbvSuro6t6WM65hsjVogZqeI1TwN430VFnB3vKqFNLIOXUUyPOReggqPLfZF2j3dYH3m/Q8+7/2jLTKF/N0k6xwzFB+Dx8ZM+az7s3KwEnLeui0oAJ6mfn7XB5MimlondfpYBz/5YpLZOZkjrgav193dJxA7hTdOU2b+K1VYiIeKIurGhx8JVXjnUugqKRW78OqbcMvSN8YkGGQyR8faIC6F4es5F1dobutxkey6E9zj6Ch4aLxXikvgBCKpd3dV7uGpreXNK/S6Jk/UfY6AQOOa8s8ag==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 10 Jun 2025 14:19:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 6/10/25 02:42, Orzel, Michal wrote:
> On 09/06/2025 22:54, Stewart Hildebrand wrote:
>> In file included from ./include/xen/pci.h:72,
>> from drivers/pci/pci.c:8:
>> ./arch/arm/include/asm/pci.h:131:50: error: ‘struct rangeset’ declared
>> inside parameter list will not be visible outside of this definition or
>> declaration [-Werror]
>> 131 | static inline int pci_sanitize_bar_memory(struct rangeset *r)
>> | ^~~~~~~~
>> cc1: all warnings being treated as errors
>>
>> Fixes: 4acab25a9300 ("x86/vpci: fix handling of BAR overlaps with non-hole
>> regions")
>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
>> ---
>> xen/arch/arm/include/asm/pci.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h
>> index 1605ec660d0b..1bbb9d780193 100644
>> --- a/xen/arch/arm/include/asm/pci.h
>> +++ b/xen/arch/arm/include/asm/pci.h
>> @@ -17,6 +17,8 @@
>>
>> #ifdef CONFIG_HAS_PCI
>>
>> +#include <xen/rangeset.h>
> Just for the struct, I think it would be better to forward declare it (at
> least
> this is what we recently started to prefer). Especially given that rangeset.h
> also forward declares it.
Forward declaring it does seem better. I'll send v2.
> That said, I don't find it mandatory, so with or without:
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> ~Michal
|
