[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen/arm: fix build with HAS_PCI
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Tue, 10 Jun 2025 12:16:42 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+HtK1z3nKFtaZip35ISlSHt5D7JyiGZrIhHJlPCdsO4=; b=BSkPbLC8aWU8uERp307otEc4V2DFC7vXZsd6Eg04Wc1D02vvtMJEgwy9SliamId6EO6b3W2Ux/qYBflzJgAwp35vCK06/B9SL9YXoTd0GNgyeNJAiOe98wFOoVk4V1MVt+dVc8GVkmWoFI8ABtUaG7BJT5COFyRwXseXrg0gQ5hOJ69NyjRP/mNc1XGm7tYdPo6sHEHevOrAFbwHmpvm7bPOXtGoLXYgZ7Ec/zmI4fIt7zCn550m19n69xfn/xpPOe9/CxeeN24TeG7JxRhJ1MWIzzcmBRPcHRR815ol5p4ilD9588wTcxhtXRDbGBLeqZRo8Qx47AEJB27cuVKLgA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w4zb6Gi2kVhMc5DfRyerfLfCiX4704V4WgEu6e3864YNgCUXCrvaSB9oBxDmeUbbt2gAFyeY9gkK8VJGZ9CNJ41NDQRhRI8BytATJfg2XYCzsy/b/96rYPKUTViKd63kN7oRmZsOucM+X0qzLihP7uq7VU7vGJEf2ho9udXXVqh9o6iPvfiPGPBnly7xKhoIy9yr91Djalkzz5EQb3knF0Rr/nRahSlIkF17K83nmNPG1LLSYY7Dc2fnMu5z67wmmgapznCbiQpYYmAuUWZNgdVcv7CfXfmHpz8KERxvkNRX0g5VoCM3pOapahLO2/5m/3dgcc8V9gncC0rPofSgcQ==
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 10 Jun 2025 16:17:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 6/10/25 11:51, Roger Pau Monné wrote:
> On Tue, Jun 10, 2025 at 10:22:57AM -0400, Stewart Hildebrand wrote:
>> In file included from ./include/xen/pci.h:72,
>> from drivers/pci/pci.c:8:
>> ./arch/arm/include/asm/pci.h:131:50: error: ‘struct rangeset’ declared
>> inside parameter list will not be visible outside of this definition or
>> declaration [-Werror]
>> 131 | static inline int pci_sanitize_bar_memory(struct rangeset *r)
>> | ^~~~~~~~
>> cc1: all warnings being treated as errors
>>
>> Fixes: 4acab25a9300 ("x86/vpci: fix handling of BAR overlaps with non-hole
>> regions")
>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
>
> Sorry, it was my fault.
No worries, it's pretty hard to catch when it can't be built without
extra patches.
> Would it make sense to introduce a Gitlab build that has HAS_PCI
> enabled? Or it won't build either without extra patches?
It requires one extra patch ("xen/arm: pci: introduce PCI_PASSTHROUGH
Kconfig option"):
https://lore.kernel.org/xen-devel/20231113222118.825758-1-stewart.hildebrand@xxxxxxx/T/#t
It has an ack, although it needs a rebase and we would probably want to
add HAS_VPCI_GUEST_SUPPORT now that upstream has that config too.
|
