[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7] xen/arm: pci: introduce PCI_PASSTHROUGH Kconfig option
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Thu, 12 Jun 2025 09:39:13 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XvAT/c0VKDKjk7ZT131qrDxyqcca2fj89igx5iZZwJw=; b=DG+VBMchVmE5JnNWovaW4RY/cS7msplRkOCGTbq/FSVhDyIjVK79R7+NZteFsDCoKJoakTTiAsC/stSW7Sgc4dZN6gDf1kO+OxvvwQshqw+aZ++dBKL8re5U3HeYkVQjRgOrd58eyBefFRI872vodhFnHzW7VyhOrDVzIAGoWf2s0+HcN97vNVd3ywNL+UK2qdlbvc4PvEk3OCNdyoo+u0SyxxeGvYhKFP07yd/PUQEyMOq5bkYJpychumsJISkUmg6zhZRnNMzTKzXZhwcrt+BgDEzzxnM+q+zoUSxjTdeoFhs1KIs2OBt+tnafMEU8K34GVqkE3Po/0kAWej3LVA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f/zNeGFgIV6OdyjTp+NOMZMZIHrbbbJC1PS1rfF7TECqnPzDpCBoeu/SyLuZTa8dLSjqZ1GHm0fhX22GkBysYTghgG29CxhtMTBLl2PyGDsGZdi/AhNdQbETp4GR2VPWsbYFvqhuWhKeKgr88vrauSHwWUi4te4snSYfyaqZVIDsFUbX9M76plFwElV+Rr2skGCsy22LXp2MphlR3N8ERDXXfs6ZfKlRgZ9PlyYxVOK65Tr/xkNb0TMbthue9Qn3Jat8S36AOf+AWszaS0zU6SbsnWEHCwK3+JQAWGJUewaKWluBJ29/LF0qSWisROLZ8o/wN1fuFj0bzCPKksgJDw==
- Cc: Rahul Singh <rahul.singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "Stefano Stabellini" <stefano.stabellini@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 12 Jun 2025 13:39:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 6/11/25 01:23, Jan Beulich wrote:
> On 10.06.2025 19:46, Stewart Hildebrand wrote:
>> --- a/xen/arch/arm/Kconfig
>> +++ b/xen/arch/arm/Kconfig
>> @@ -258,6 +258,16 @@ config PARTIAL_EMULATION
>>
>> source "arch/arm/firmware/Kconfig"
>>
>> +config PCI_PASSTHROUGH
>> + bool "PCI passthrough" if EXPERT
>> + depends on ARM_64
>> + select HAS_PCI
>> + select HAS_VPCI
>> + select HAS_VPCI_GUEST_SUPPORT
>
> What about HAS_PASSTHROUGH? Seeing that being selected by MMU, what about
> that connection here?
Hm, yes. I'm not sure if depends or select would be better?
depends on ARM_64 && HAS_PASSTHROUGH
or
select HAS_PASSTHROUGH
> Selecting HAS_VPCI shouldn't really be necessary; HAS_VPCI_GUEST_SUPPORT
> does that for you already. (I further wonder whether HAS_VPCI wouldn't
> in turn better select HAS_PCI.)
I'd be happy to make these changes.
>> + default n
>
> This is unnecessary (redundant) and would hence better be omitted.
OK, I'll remove it.
|
