[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/6] arm/mpu: Provide and populate MPU C data structures
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 13 Jun 2025 15:39:20 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xOeunrsjP1nZaW+DLJHQ+Z0jzivpn/v68lRbvAtK0V0=; b=zCfImC3mnlYCKkY3o0tpLXeeIJExzYRL10h/Q2yH0aJHNITqXM9LZOpDel8+sVQjivGDPgb4guz010NmUWmjqiJq8CYqnbpEdOhz12LBlEzcK1XeTls5zIivr6Ie73MyTAWXsyX/NfDOe33IbEnneEBV9pRZRDAR5YPE3WSnNLrKUZ9wxI9osmPBFFkpEeDURnXxygy3fgQ8Nh5DopejWkOkLKXkhdfN/uXEtW53bSNw+dkCyzba1OzickgzMI+frrmLWyQ1PknYw0nP56LG9QY1o+e9gYP+xtmjmoN4MAmF2kOqo3vncZ+eThOn/l5bLWKRkRO1sv3KJtcLEbrHYQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xOeunrsjP1nZaW+DLJHQ+Z0jzivpn/v68lRbvAtK0V0=; b=liVk+XaS/WYru8IHD7c1L/H9A3boTPJIbtRNLVXbv0hvIg1216PvIo9pHnoNQeOATVREofxmiwmIkYZo6VCa3TgW11XlKnQDlOCP6+b/TWpwKpx2ickXv4TVnEGNICWrvHKjJwcFOtawUE44kcCryZL58UI4AN0d6PD/XpIsrhqARDwAX1Ck0rleiSkZndIT6oxYAZOA4xS+8Xw1XJ7XngwlmLwncboNu6E00EVAi5ssOvVFurkXgrmRKxi9RvFxbbGT+je7kGQFfKtkyWJ9jUPHTHadC/CxFtManszbK/xUpvnM8kxpW54eGGNI43TaL+4XB+3TADu6SAgTwNg8gQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=EFK/KbcPj9Ns3d/AkuwQWUnSAsRyFXsFDahLebJYlEC2TDp7EQrios8pYCI7x6Ll+FN/l0KPGMDQzv20GGL4ZdRNCFSZUYbtPbA/xFx19aP2vDq8H98+ENu9Z6apKEC4IDv8YPF6WpSPa6kbvMjuUXNQ1v9r2VSoLS+gXMJnx0Hux+eGtqpMezy5v7qq90aVB1WDAh2VIV7txbAQtAqhnVDG6guu2ghkNdR8tqVyTiAz2inZj3xpw2ApxkHq/wuiGwqA8QOYXsOD9mnZoYZ+6NCHjJlrmXkCfpqgJ742B/6X4ukezx4dSRzRemUFpTv8obIy+dBoUIdw/F2KWWAc5Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G6S/Elf97FoRfypsp78D5nt/UgkEyNXhoULjvdQfWl/AHd+tCFGRsFjmD95kTknYuFUmfLhuKXea6NhDdXTlLWLSY3T2+w5m8icvkyQZD6ymO5XvgubNbWz40pFak93nhwdJ/KYiPIQAt3nnYtzewQp2Du/YH+SGBwZ/x/9/qkbqbrNWqLNHo6eaB0yGd85omL58bKsOWzU8XGEfa7AcvmZxJ93lMHqyJY4Jumi0Zp6yOcm3UD/3bW9NF6DGbiWRZiG9pM9+zHEad50KZhSN9sNMPhidfAFf5u22/0S+15b+gvfWIX//h7WMHAkZ+mytjUn+8iF6fQxNyLX7q7PMMA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 13 Jun 2025 15:40:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHb2t5PH46Li7ClPkCuT4B0B2toC7QBPMgA
- Thread-topic: [PATCH v3 2/6] arm/mpu: Provide and populate MPU C data structures
Hi Ayan,
> On 11 Jun 2025, at 15:35, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> wrote:
>
> Modify Arm32 assembly boot code to reset any unused MPU region, initialise
> 'max_mpu_regions' with the number of supported MPU regions and set/clear the
> bitmap 'xen_mpumap_mask' used to track the enabled regions.
>
> Introduce cache.S to hold arm32 cache related functions.
>
> Use the macro definition for "dcache_line_size" from linux.
>
> Change the order of registers in prepare_xen_region() as 'strd' instruction
> is used to store {prbar, prlar} in arm32. Thus, 'prbar' has to be a even
> numbered register and 'prlar' is the consecutively ordered register.
>
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> ---
This LGTM, I’ve also built for Arm64 and Arm32.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
