[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Fix P2M root page tables invalidation
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 16 Jun 2025 09:38:46 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EYPssxpM01uvcl1obr7ERAD+Jpn7E9jmoJc7gDu1iTA=; b=E2mh4TfkfdD8oaY+IJtVeUOzueCUniAkCvL5kb7M8WIFER4rH+UNI+1w2V1YIw3vduRo+khONUd8la2NQrl3zmRGgdAN9YDcn7tacN9lLO/itxDEYwcVanY3zIgdeM6K6gQCiKZeHEFBP9gyYDCr5s8DxPXi38z7/mQj4seBQYznRVic4YZxwmHvIS4/yzK5eVSkX9AFdMBT+TD06gizY13X8TxJHGwD9g4X135+0YO+wN1ojeXVXJdqy1byoOVmpfazVxQlPFOZx2Q0+Ryan9n26UKM7g2Vn6j8gNH1XTpT5k9040ZndOFMVOMO4nWM+SlfnSQythZ2UjxYritJbA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gvRu9TFyPKCgnPMeflae0wu0y2Lgb+S4sJq1h2FNBtBPO6/fNR1/kvl3VF83bJP/8DgORSskZWqQEUGimjWy/ssf1mPZnTsuUVeILCy4zum19QNQFNA0Dsnk5jvtYzMT3mNnrflkOQfMEMNC/OGuQHn/kP8tP3xwUZhMXbJUe0rKysu1HRPuhK2B1FWido1v7Vt+i+bBSsojvJM18AuU57WAy16PezB5lSwoLy2hYEoLWakVzX+i+JKGwT/AjOZ7uZnsxxudpwNdIl/By7s7W0qth2iLNZX7LC8ARRElSAkmcD+tRFl1bVoie8Q/spjPqgayR5Yj4jylGjD9RCHxOw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 16 Jun 2025 07:39:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/06/2025 09:35, Jan Beulich wrote:
> On 16.06.2025 08:56, Michal Orzel wrote:
>> Fix the condition part of the for loop in p2m_invalidate_root() that
>> uses P2M_ROOT_LEVEL instead of P2M_ROOT_PAGES. The goal here is to
>> invalidate all root page tables (that can be concatenated), so the loop
>> must iterate through all these pages. Root level can be 0 or 1, whereas
>> there can be 1,2,8,16 root pages. The issue may lead to some pages
>> not being invalidated and therefore the guest access won't be trapped.
>> We use it to track pages accessed by guest for set/way emulation provided
>> no IOMMU, IOMMU not enabled for the domain or P2M not shared with IOMMU.
>
> IOW no security concerns?
I discussed this with Julien and we don't think there are any.
>
>> Fixes: 2148a125b73b ("xen/arm: Track page accessed between batch of Set/Way
>> operations")
>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> Credit Oleksii with a Reported-by?
Sure thing:
Reported-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
~Michal
|
