[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8] xen/arm: pci: introduce PCI_PASSTHROUGH Kconfig option
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Mon, 16 Jun 2025 06:37:55 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7EmsksXGREpSy7vy4sYjcDMmvpG7ntID6tOBSgLkHf8=; b=SUxaLuyqYMNL0Oa3trWjozDa1wtivzbmsmpl6YSHTDE+hKm5vJjhTAR+VK08xOk1kOCmQ1EGjaTnw43lIkwvABmYlJf0C051KkqaCsBhMP65jS7jSw+/hlzI3Z2/DV75ZBujcx8usJ/RfMJxthDZnR7cDPK6/LYibd5J2zQP5oBXnaxyPFRzc/y9zZHxIyirhUZ4jC1vD4j1mKi7pwu/ZXNMPZvw4Cari2OUsvqUlkJfIZb5Wc1O00DGJs+k5/A4gOGfrG0YvZI+MgV4B7gpIvfI8uR53xFLA3nYqDaaNlTZzl43aNvFG9bqkk15ob6wDNKl5t0qoMHVy6bu8d2t3g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VeYxcrcTqC4Afuxzj1xH+0eNLocxVikKvs52YVChTSsu2BP22umBs8Fz2AJcwcl/RK4zw3gTDKGY/1GO6nZi1Da59PjwvIv+IagW6sqW61Vuck6g7HglcEx9D8MDvetOkiXlC7SvjVPok//eeraSrlILexNxTpBktQf+I7zxMQX50AM9wvT6KmEcMvxZzKCt6m9Smy6cuhthwAwzofpn8Vs4BdpoXbORPYN5WO3G1+uTLtqkBnJlp/DznoQ7C2WGbcuu9e+UAtntOm0fVArzc0ZAoLbPg/A0268mbxafPJl5qLDkgStv/L12E5jKAQ/ayuaj9iATZN+S/N1hmSS2VQ==
- Cc: Rahul Singh <rahul.singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 16 Jun 2025 10:38:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 6/16/25 02:42, Jan Beulich wrote:
> On 13.06.2025 17:17, Stewart Hildebrand wrote:
>> --- a/xen/arch/arm/Kconfig
>> +++ b/xen/arch/arm/Kconfig
>> @@ -8,6 +8,8 @@ config ARM_64
>> depends on !ARM_32
>> select 64BIT
>> select HAS_FAST_MULTIPLY
>> + select HAS_VPCI_GUEST_SUPPORT if PCI_PASSTHROUGH
>> + select HAS_PASSTHROUGH if PCI_PASSTHROUGH
>
> Seeing this, I like this as little as I liked ...
>
>> @@ -258,6 +260,12 @@ config PARTIAL_EMULATION
>>
>> source "arch/arm/firmware/Kconfig"
>>
>> +config PCI_PASSTHROUGH
>> + bool "PCI passthrough" if EXPERT
>> + depends on ARM_64
>
> ... the form with the select-s put here. I'll (obviously) leave it to the
> Arm maintainers to judge, but my recommendation would be to simply drop
> this patch. As per the description it's merely "make it easier ...",
> which imo doesn't warrant such an abuse of HAS_*.
"easier" was a poor choice of word. "possible" is more accurate. This
patch addresses a real issue: currently the PCI and vPCI bits can't be
built for Arm, allowing build issues to go unnoticed. E.g. see
4ce671963eb1 ("xen/arm: fix build with HAS_PCI").
|
