[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 14/14] kconfig: Allow x86 to pick CONFIG_DOM0LESS_BOOT
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alejandro Vallejo <agarciav@xxxxxxx>
- Date: Mon, 16 Jun 2025 16:12:46 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rx7lp/ksjiw0VI7/3FfQcZx2MJDnwmnHgMFliPWDJXM=; b=wLX1jU5bJd4wzEJH9exZeQ0gbTwfv96uUi7qLVY0ay22nl3VN3/wo7LS85LSe4Fr7ablQW9OyyFiKNREcx0DUhK4LglQincJkZnQytDBrZ69rO26UfeNvqDMD18XJPQrI6YyPOFYwEMNFC70QxNt7nbUgvTmnYL+WPTpkPsIm5NqCCiz2EbPZp6lK3/o2FJFlBnldqMqzZTuqFb7r3btFDXCiScpU32mtkslCCp5HcS5enfxgj2CJG2hmOQGpYLp35vNdgAqBDQc+4kONVq4NYEWs4rzfwbxh62bA7WTMXfgajecx8PFkIrYw1vPFXtkB/cD2+STV46aQJgvLpXyCA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yZzH1sRv/Ro8GIwcU15iQ7Ru1+N9S4R2KcL26EPGW5Gh2ZG4z+SwXkt2bPwjozabLYMSAqaq8xA7fW8P2/Rb2FPZGhev/nb2u8GuTp9IDjd/ulx0ljrl0AJoMFT1y5rEXzMm3WEbMoVl6CQhHFcTeDM7uRxfFw/cm7f/LKDpj0LPsE6IpSSA2jAXETqAk6DSeEGCo2Od/IweAfxPzUdsjA5nFHJ7Mww5Qb4XYjcDUZ4CIJ81aNkrTs4/hcwrMdbz7MzeORhr/hnMBzd3tg3wQ5QSMjKjSxnVONBQ3mfLs4N8eLgZTmkElqnunV3x8AY55GTVdCZUwnSWXOwsLpXX8g==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 16 Jun 2025 14:12:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon Jun 16, 2025 at 8:59 AM CEST, Jan Beulich wrote:
> On 13.06.2025 17:13, Alejandro Vallejo wrote:
>> Without picking CONFIG_HAS_DEVICE_TREE.
>>
>> In order to do that. Allow CONFIG_DOM0LESS_BOOT to enable a subset
>> of the common/device-tree/ directory. x86 doesn't want dom0less-build.c,
>> as that's tightly integrated still to the ARM way of building domains.
>
> Which then is grossly misleading: x86 also ought to select HAS_DEVICE_TREE
> if it wants to use that machinery. Instead of theis an the previous patch,
It wants to use a _subset_. I can't use the full machinery.
> I think what we need is a new Kconfig setting to control the use of
> dom0less-build.c.
>
> Jan
It's not just dom0less-build.c. It's critical to avoid parsing device_t's
during the unflatten procedure (which is the few lines compiled out with
ifdef CONFIG_DEVICE_TREE).
Renaming CONFIG_HAS_DEVICE_TREE to CONFIG_HAS_PLATFORM_DT (with a suitable
`help` message for clarity, even though it would always be enabled) should
help clarify things.
Does that sound reasonable?
Cheers,
Alejandro
|
