Golang review, was: [PATCH v5 5/5] tools/golang: Regenerate bindings for trap_unmapped_accesses

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

Hi Nick,

It would be good for you to review this patch.

If you are unable to do so, please let us know if you have any
objections to us committing this patch without your ack.

Cheers,

Stefano


On Mon, 16 Jun 2025, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxx>
> 
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xxxxxxx>
> ---
>  tools/golang/xenlight/helpers.gen.go | 6 ++++++
>  tools/golang/xenlight/types.gen.go   | 1 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/tools/golang/xenlight/helpers.gen.go 
> b/tools/golang/xenlight/helpers.gen.go
> index 90846ea8e8..191be87297 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -1170,6 +1170,9 @@ x.Altp2M = Altp2MMode(xc.altp2m)
>  x.VmtraceBufKb = int(xc.vmtrace_buf_kb)
>  if err := x.Vpmu.fromC(&xc.vpmu);err != nil {
>  return fmt.Errorf("converting field Vpmu: %v", err)
> +}
> +if err := x.TrapUnmappedAccesses.fromC(&xc.trap_unmapped_accesses);err != 
> nil {
> +return fmt.Errorf("converting field TrapUnmappedAccesses: %v", err)
>  }
>  
>   return nil}
> @@ -1695,6 +1698,9 @@ xc.altp2m = C.libxl_altp2m_mode(x.Altp2M)
>  xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb)
>  if err := x.Vpmu.toC(&xc.vpmu); err != nil {
>  return fmt.Errorf("converting field Vpmu: %v", err)
> +}
> +if err := x.TrapUnmappedAccesses.toC(&xc.trap_unmapped_accesses); err != nil 
> {
> +return fmt.Errorf("converting field TrapUnmappedAccesses: %v", err)
>  }
>  
>   return nil
> diff --git a/tools/golang/xenlight/types.gen.go 
> b/tools/golang/xenlight/types.gen.go
> index e7667f1ce3..656933c6c9 100644
> --- a/tools/golang/xenlight/types.gen.go
> +++ b/tools/golang/xenlight/types.gen.go
> @@ -606,6 +606,7 @@ MsrRelaxed Defbool
>  Altp2M Altp2MMode
>  VmtraceBufKb int
>  Vpmu Defbool
> +TrapUnmappedAccesses Defbool
>  }
>  
>  type DomainBuildInfoTypeUnion interface {
> -- 
> 2.43.0
>