[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] console: Do not duplicate early printk messages on conring flush
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 17 Jun 2025 11:52:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wX+USrUT6qkhyvuW01KYiizlOIB5ks+AR8MFu+veyhY=; b=SVSC4GOsRkq7PBn7b8LcNqOrFDLDgaSqbAYalODbxtdjDSYr7TpHuBgR8mm6qM/U2VUmN/W9Vucip1c33kH82yoa+QuflM5HqF/gIIxdXeV+ZLCcGHmi2ObBQHxDKaNxM+id6CE/gVl5KSfTdUTblRFawQI85Z+4EW4FCOC2balz9ahJxrOONzR5l6rUNdcT/TVc+BelWdzrkfT8XINgpZq7lDw1Ih1n672CCP/hMDC4hmVcRT4RF/9Qz2czLcuPnlM0CiCZuJ0HHM+hHdz08xcQ8C2EmKVKQZWPlsVEWFftfmSY3bzcTVai4u83vms2WLUx4PtFmnntYhgHKXNnUQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=K5CgG31FhWVc7l1L4AkbeCtxKdZe/23mqyTtOLjH5yMGKqsrJOdjAbkVZI/8z7ovVCiq6iHplk9WroVDLcqGAeVoBxpnw6WhJPpHaJtcGbE42aLH0Goo+sUMTlgkSgaLu5hzCXXOu2WPNaAS4nvz5sBe4avn1EfC2+9HX2FXZqhutxxKOveYHVSeTVNItXzWnTogT/xVTq8cmE+FfeLnc1NRkttLkD2cZO2mZfxjHxjWwHKgEKNV+U50oggTiydTBqTGYHo3DkZyb1rzF3vq/oFDjcUcGSL+xXcZ1/chT0w3fEoBCKpk3j9CmTe4OYACcl28loInqRdAPFoK3j+SKw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 17 Jun 2025 09:53:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17/06/2025 11:26, Jan Beulich wrote:
> On 17.06.2025 09:19, Michal Orzel wrote:
>> @@ -1084,8 +1085,15 @@ void __init console_init_preirq(void)
>> serial_set_rx_handler(sercon_handle, serial_rx);
>> pv_console_set_rx_handler(serial_rx);
>>
>> - /* NB: send conring contents to all enabled physical consoles, if any */
>> - conring_flush();
>> + /*
>> + * NB: send conring contents to all enabled physical consoles, if any.
>> + * Skip serial if CONFIG_EARLY_PRINTK is enabled, which means the early
>> + * messages have already been sent to serial.
>> + */
>> + if ( IS_ENABLED(CONFIG_EARLY_PRINTK) )
>> + flags &= ~CONSOLE_SERIAL;
>
> Does EARLY_PRINTK=y alone guarantee everything was output? That is, is there
> no chance that early-console init may have failed? (Sorry, I don't know much
> about early-console in Xen, as that's Arm-only.)
There is no init function for the early printk and no function related to early
printk returns something.
~Michal
|
