[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 06/14] xen: Refactor kernel_info to have a header like boot_domain


  • To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Alejandro Vallejo <agarciav@xxxxxxx>
  • Date: Tue, 17 Jun 2025 12:05:54 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=apertussolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JQIRDRDP+DrnJgoJHFlAKc3k8AM7vs3qKBi025NYhP0=; b=podLQLwLm57rstsSKvZ87uJjncFe888ZdBiU0PSAnhh7FDTRH2ZuBmk2VPzLqrBzU9Gw0SnV3tcK/fllkAzK+iVRaDE2DXxAJqQmZMrIz3rt9tArY6gDkyyl+8mv7M62U+WdgoeuOqOzaGNSqCEy9pTN5nzpoqaiE27WIUYwqCniqftYKBkp1PCXaM7XrtDyosxs7RKPe2/EWuCM4bHKMAOgkMRWoe8wG2oGIUVK8+itdy2ptEg1riKwR3eJvfciid2N7l8nPEaoNMM4Z859aM7a6v2zTZHe6nA2xkQO9+ZZgPpjLuIRoB8OQiNLm2QwUjhNjHbqNy6derK3CXH4Pg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G3Dh9wimFpSXCRD2z9j157l0Lp5l21Yby+BG+s/NNY+eDH0KNveknVA4TzrWEgWUx3d9PHm5+XVIt3ax+eRgzFXHtyOOzIAr4RkdUBRGwWKdNDDJHC1yDvGQJqs5TiYTPKL4RyXCYZZp+WgWmgsjjeQ83Iva9knbb45yq35J9aFn9su2i3SvfPkWxj4TeXQUGglRzGFNhhXNToJrAMPKewj4orJByMnpfR+vRJPsFdbKAIyVIIiwUvjKKAN7QnIiEA3nvQLHtwjm3/ERdx8E+huNkCByRJMkWwrrz9lfc2SJSzLYffEWf9AOoxbPtxM3qiILhBbBaEiRPelyytn0sQ==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 17 Jun 2025 10:06:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue Jun 17, 2025 at 3:22 AM CEST, Daniel P. Smith wrote:
>
> On 6/13/25 11:13, Alejandro Vallejo wrote:
>> Create a struct header within kernel_info with the contents common to
>> kernel_info and boot_domain, and define that header in common code. This 
>> enables
>> x86 to use that header as-is and drop x86's boot_domain
>
> IMHO kernel_info is an extremely poor name for this structure and 
> hyperlauch attempt to resolve some of these less than optimal choices is 
> being undone.
>
> v/r,
> dps

kernel_info is a big misnomer, which is why I originally typedeff'd it to
bootdomain_t. Note however that at no point (in v3) does kernel_info reach x86.
The header is effectively what was already in boot_domain, except it's common
code now so the domid field (not yet included in dom0less) goes on an "arch"
subfield. And x86 only uses that header and doesn't know or care about the rest.

Cheers,
Alejandro



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.