[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/3] arm/mpu: Move the functions to arm64 specific files
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 17 Jun 2025 13:27:19 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sK9BICF0G35sXATrXxrFQ6Qn6ZiR7c6VekeQ/UCU0I8=; b=wCMktTu+Pe3/JPii+woT1TGaWdN8/cw3IX0Ri4HpUicT0DeP8RKEdR4F0FjPRt2mlOSakHbTz5PoOxrYTDYrDnGZXdrxovky/U2l15p7obxUG2jHxrZYJrpUYNSt5D4hjZAXAu/p371e3kb6+D9ZNaOXu0ypB5j+Ncfc9P8gg3M5UhYd7sBbFw/hvHOFoO2RiAqzobGn/rOcWagCSEW7FMGbm4xbdHZYiIPyvSL61ZYGoTT5l5f+8hPThAD/AuVsTo+fH7Rgju673tR1B8NlPFI9wW2zy0oABEICW/LdEXC6NZhJft66FqlfgVOPBHPvaNH5rFpbo2/JYDeckS8Viw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rJi/7x31xdbTiaOT4SSC+h/SLTMl7tt+J+zmiu6I+KI3KdLoL2khhRXeE8MiACs7ZcObtyHnx6fT+NmLO7TbY85YmlFvm+gZbGeu/LGhsrMh0S9EPYQnYl+d8JWCuOxvqvlfmToe9vO1qAYpJ7pHd/KIG7j4pVzQ1FthhM9WbB5D18bLBbP/eO+7pnwGLV77FIFnbo/BDHrNbpW9tMZ17BwZkOSv/LL24MAS2W9zd0uvE8qghfoRIfmJkYpMYUPgLLxO/O5NzDCcGEMBDBvAXZKkRSIG1HfETkVbO2WprzDuHbOz+sc6TFsrVCEVN682WsaY/TfXbsZB5kWiQmrLYA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>, Hari Limaye <hari.limaye@xxxxxxx>
- Delivery-date: Tue, 17 Jun 2025 11:27:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17/06/2025 13:12, Ayan Kumar Halder wrote:
> prepare_selector(), read_protection_region() and write_protection_region()
> differ significantly between arm32 and arm64. Thus, move these functions
> to their sub-arch specific folder.
>
> Also the macro GENERATE_{WRITE/READ}_PR_REG_CASE are moved, in order to
> keep them in the same file of their usage and improve readability.
>
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
> Changes from -
>
> v2 - New patch introduced in v3.
>
> v3 - 1. Add Luca's R-b.
>
> xen/arch/arm/mpu/Makefile | 1 +
> xen/arch/arm/mpu/arm64/Makefile | 1 +
> xen/arch/arm/mpu/arm64/mm.c | 130 ++++++++++++++++++++++++++++++++
> xen/arch/arm/mpu/mm.c | 117 ----------------------------
> 4 files changed, 132 insertions(+), 117 deletions(-)
> create mode 100644 xen/arch/arm/mpu/arm64/Makefile
> create mode 100644 xen/arch/arm/mpu/arm64/mm.c
>
> diff --git a/xen/arch/arm/mpu/Makefile b/xen/arch/arm/mpu/Makefile
> index 808e3e2cb3..5ad15e93be 100644
> --- a/xen/arch/arm/mpu/Makefile
> +++ b/xen/arch/arm/mpu/Makefile
> @@ -1,4 +1,5 @@
> obj-$(CONFIG_ARM_32) += domain-page.o
> +obj-$(CONFIG_ARM_64) += arm64/
I think this should be above domain-page given alphabetical sorting.
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
