Re: [PATCH v3 08/14] xen/dt: Move bootfdt functions to xen/bootfdt.h

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 19 Jun 2025, Alejandro Vallejo wrote:
> Hi,
> 
> On Sat Jun 14, 2025 at 3:16 AM CEST, Stefano Stabellini wrote:
> > On Fri, 13 Jun 2025, Alejandro Vallejo wrote:
> >> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
> >> index 75017e4266..0a22b1ba1d 100644
> >> --- a/xen/include/xen/device_tree.h
> >> +++ b/xen/include/xen/device_tree.h
> >> @@ -10,6 +10,7 @@
> >>  #ifndef __XEN_DEVICE_TREE_H__
> >>  #define __XEN_DEVICE_TREE_H__
> >>  
> >> +#include <xen/bootfdt.h>
> >>  #include <xen/byteorder.h>
> >
> > This should not be needed?
> 
> dt_read_number() is still needed in dt_read_paddr() in device_tree.h
> 
> I can move that helper too (makes sense, as it's strictly a wrapper) and
> add includes in whatever .c files require it (tentatively it looks like only
> static-evtchn.c. Then that include can be dropped.

Procede as you think is best. I thought it was unneeded by code
inspection, then I tried to remove it and Xen compiled okay. So I wrote
that comment. If it is needed it is also OK to keep it.