[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [MINI-OS PATCH 1/6] suspend: drop crazy pfn handling for PVH
- To: Juergen Gross <jgross@xxxxxxxx>, <minios-devel@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Fri, 20 Jun 2025 17:36:36 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8CPsrEbMQLXOUUqeM2LQ9iP8HdATRM5wn0XASA4Dh1g=; b=CwLo2/Kexq8KZjIwOmTSKCcR842t7KrVSBVlNi4dwsnwQwtB8OdRF6mocswMW5lKjIPii2cKodqGu07zGhFpydgM+Q2J7CnQTUb0jDwQftBong20p3NM8UnRzVUJM/rb6mG3cS7pooX0yEYieax8kkee6fGKoCjJRkG1Oh10hkqOPs+LPPXN1ac7GEVCvI4XqaXUcRGoe8Jzqyhl3DvVMkJO+M7FulaKhvu/gJvFS4nmffKYpc7PWFGxZL8d6sQS6k3ZAcYnZfn+mYj6ApnxXV6Lqk5B+tghWM7nP5aD1hEwMus6GK/tS7hzGNq6upjSeywdf8OjSZYhnzjFnTDKlA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kJXY3t4QEv96ozd69IHWVzWGSHNaHl033706gQVPDWekXEdq5rjXo4nCJHthyPgPw3gcIfBZTBvOzS6KfZFISItqZrrvu/3/sNLA7MbVwI0GQ6VIcBEW9KYp1iSbZ7ERlvkCee2pOySzB/71oIkltUCCDm4DJbY3mpiuT6p4STweSxrM0QBSAinSo3WPuHQUWRj5C+6v3B2JjhoJxyhO6E4FG+y9DYj5iC5nE3mf+9ropgn7xY3xLfWmTSntwEipqna9PvugDLjqPUPqrzOF8VGN3WF5gwcmSM3ZO21ul8u27owyVI4fvom57XuluktOQhyj4TIFjFJZzzHEQLuLdg==
- Cc: <samuel.thibault@xxxxxxxxxxxx>
- Delivery-date: Fri, 20 Jun 2025 21:36:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-06-19 07:37, Juergen Gross wrote:
Suspend for PVH is doing some crazy stuff with the Xenstore and console
PFNs:
- In arch_pre_suspend() the PFNs are "translated" to MFNs, even if that
translation is a nop.
- The result is stored via start_info_ptr, which points to a struct
start_info only in case of PV mode.
- After resuming or a cancelled suspend, the PFNs are retrieved again
and "translated".
- The "MFNs" are stored again via start_info_ptr, which is still not
pointing at a struct start_info, and from where the data is never
read again after that.
Drop all of that completely.
Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
start_info_ptr points at an hvm_start_info. Assuming I counted
properly, accessing ->console/store is writing past the end of the struct.
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
|
