Re: [XEN PATCH] xen: fix header guard generation for asm-generic headers

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Sat, 21 Jun 2025, Nicola Vetrini wrote:
> Dashes were wrongly not translated into underscores, thus generating
> an unexpected guard identifier.
> 
> Fixes: ee79f378311b ("xen: add header guards to generated asm generic 
> headers")
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>


Thank you so much for the quick fix!!

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>



> ---
>  xen/scripts/Makefile.asm-generic | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/scripts/Makefile.asm-generic 
> b/xen/scripts/Makefile.asm-generic
> index b0828018080d..f6850758c54b 100644
> --- a/xen/scripts/Makefile.asm-generic
> +++ b/xen/scripts/Makefile.asm-generic
> @@ -34,7 +34,7 @@ unwanted    := $(filter-out $(generic-y) 
> $(generated-y),$(old-headers))
>  quiet_cmd_wrap = WRAP    $@
>        cmd_wrap = \
>       arch=$$(echo $@ | sed -n 's:.*arch/\([^/]*\)/.*:\1:p' | tr a-z A-Z); \
> -     upper=$$(echo $*.h | tr a-z A-Z | tr '/.' '__'); \
> +     upper=$$(echo $*.h | tr a-z A-Z | tr '/.-' '__'); \
>       echo "\#ifndef $${arch}_GENERIC_$${upper}" > $@.new; \
>       echo "\#define $${arch}_GENERIC_$${upper}" >> $@.new; \
>       echo "\#include <asm-generic/$*.h>" >> $@.new; \
> -- 
> 2.43.0
>