[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] xen: fix header guard generation for asm-generic headers
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Mon, 23 Jun 2025 10:41:10 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1750668070; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=Apxn1EwW5jUNFbwowZsf2yZNLKfqblG8Xvr0MqKrexM=; b=qGpfBxsjahKv7eXIbiswfat7AhKOcKHPQGYRl+jUJ3/Xjp3a3Phe4jh1oLz02d2/DCMK 9eXHTYMw4d7FPuDlg7fcQiml6QwD+hsUWLNbZ/OPM1D7dGSjlfJW+mAhzABpJ5qArbUBX dGIve+SxBSM9tPaieaibx/DjZ/XIKFjUNJTwjW3pp+uVWbymkwD1Y6EXxlipkuSUWy+4d GAUsTPZj57xHP409Sdh60zi+JB1V5otHMT3qwdEZrveQKLpmcrcBZV7Zci4RZfL9NKdQf gOcIq7z2clQCUWrBV35kZwvyWV2Cub4SJnDqFIx5gnn0v2K74SQuTNTg1sO26U2PBRg3s 6nfTia28vcp7IUQyykbEoWYF8weFbNaxg7FTQad4ORpJ8hBJUH7t9bziWRcwOr20shuOe Qco7o/1Ryg9zO60hul4LqBl7YiNXgnRAp0M9Co78ChSZDmWQD5lg+VinNd6AfIFaGQnsH qmDOEowcinRHJqf4tVC1JJoqVrC6h9XmwhUickGjWuWa0i9J58Rd9txFyJTnnyAk1HqwR 9b/YfFTGJqXK22/pY/Sw25nNB1r0tYNc1+M3zdrDqNEovG4HMuK3v/spTpu9532O5CfSZ 6KfXJQ+22IiLD3h2FEzAj21nLlw2ANPEZ63gNUiuIA+tbNmZvjkPAGSCZH4jeEg=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1750668070; b=yyDuwEjhnt6FWDqwURyYe7SuaRiJ0ofqEBIeeV89l+PR9Ad3T6nHHtHgXG6ie8l/EafS mUBjbOhygvrQiLDhnnrlbsXEbYjmy3QhqbubbmzGSOc5itTY/UHhBcEjySAY8u7s2VN8d G2CGKGhSO14+ZIVRvNTIgjrCxCLyp64e/KXQCNJIHfmeS7mqmeJRvs+gZ7dQDrCVNn1er NsEvv8l5/voVc3QmnuuUY5HDWqeO+xmbkQyUXhfhE0zshxc277nIKrQh1Y08007HBQ79t 8EUCfSc7LVXHRYrX2PWPp2jZa6fbFtNPhWgKwfcG1xMmgjLNwrv1P5p2XVhoEvV6DU8HE kPDt0hixmIOTlfD6dyXqNb21/0rKEQyOSuRl46MZ28y3E3I6K5lyuO9qetyvmz7N2bBLz AqDOJbFDk5K3DO0oFnSzNhWYbCe+NAQD8NzCRn1UldEmNkDJVftbvC9jljRnYkBYOxBH0 jD1so1dWKjSQVDz4D1mETtWi8tvFczeM/dtHkbHPiyMOt4JzASG+hZfP/dUAX5NHp1Chq unYxo7u88rGA0LurZqSI6+5qOLQBqpAwafLMXLXR0WKQ2gmFv2vaxA/1HsUOH3xT/Dp7+ w6J03vQOhMkX831YK3DiSFeYGLjTRHsC3kJviBf0CqbRmjv4Nux4f0TmwJ8kjGg=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 23 Jun 2025 08:41:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-06-23 10:20, Jan Beulich wrote:
On 23.06.2025 09:51, Jan Beulich wrote:
On 21.06.2025 11:58, Nicola Vetrini wrote:
Dashes were wrongly not translated into underscores, thus generating
an unexpected guard identifier.
Fixes: ee79f378311b ("xen: add header guards to generated asm generic
headers")
Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
xen/scripts/Makefile.asm-generic | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/scripts/Makefile.asm-generic
b/xen/scripts/Makefile.asm-generic
index b0828018080d..f6850758c54b 100644
--- a/xen/scripts/Makefile.asm-generic
+++ b/xen/scripts/Makefile.asm-generic
@@ -34,7 +34,7 @@ unwanted := $(filter-out $(generic-y)
$(generated-y),$(old-headers))
quiet_cmd_wrap = WRAP $@
cmd_wrap = \
arch=$$(echo $@ | sed -n 's:.*arch/\([^/]*\)/.*:\1:p' | tr a-z
A-Z); \
- upper=$$(echo $*.h | tr a-z A-Z | tr '/.' '__'); \
+ upper=$$(echo $*.h | tr a-z A-Z | tr '/.-' '__'); \
Aiui the other argument also needs to change, to '___'. While some tr
implementations
may cope, the spec is quite clear:
"When the -d option is not specified:
Each input character found in the array specified by string1 shall
be replaced by the character in the same relative position in the
array specified by string2. When the array specified by string2 is
shorter that the one specified by string1, the results are
unspecified."
Easy enough to adjust while committing, I suppose.
Except that I notice that this was committed already. Will require
another
fixup then, I expect.
Jan
My bad, GNU tr seems to cope just fine (i tested running on all Xen
headers) but another fixup is in order.
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
