Re: [PATCH v1 01/16] arm/vpl011: rename virtual PL011 Kconfig option

[dmkhn@xxxxxxxxx]

On Tue, Jun 24, 2025 at 08:13:08AM +0200, Orzel, Michal wrote:
> 
> 
> On 24/06/2025 05:55, dmkhn@xxxxxxxxx wrote:
> > From: Denis Mukhin <dmukhin@xxxxxxxx>
> >
> > Rename CONFIG_SBSA_VUART_CONSOLE to CONFIG_HAS_VUART_PL011.
> Why? We emulate SBSA UART and not PL011. Despite the similarities (the former 
> is
> a subset of the latter) they are not the same. I find it confusing and drivers
> for PL011 might not work with SBSA UART. Also, in the future we may want to
> emulate full PL011 in which case it will be even more confusing.

That's because the emulator is called vpl011, but yes, it is SBSA UART.
I will adjust to SBSA, thanks!

> 
> Also, why HAS_?

My understanding is that HAS_ is the desired naming convention throughout the
code (not documented, though), e.g. all Arm UART drivers are gated by HAS_XXX
(e.g. arch/arm/platforms/Kconfig).

> 
> ~Michal
>