Re: [PATCH v1 14/16] drivers/vuart: move simple MMIO-based UART emulator

[dmkhn@xxxxxxxxx]

On Tue, Jun 24, 2025 at 07:53:04AM +0200, Jan Beulich wrote:
> On 24.06.2025 05:57, dmkhn@xxxxxxxxx wrote:
> > --- a/xen/drivers/vuart/Kconfig
> > +++ b/xen/drivers/vuart/Kconfig
> > @@ -3,6 +3,15 @@ config HAS_VUART
> >
> >  if (ARM_32 || ARM_64)
> >
> > +config HAS_VUART_MMIO
> > +   bool "Simple MMIO-based emulated UART support"
> 
> Perhaps in a separate change this should be renamed. HAS_* should never
> have prompts.

Oh, so HAS_ flags are non-interactive selectors by design?
I did not find explanation in the docs :-/

Can you please explain?
(and I will add a note to docs for that)

> 
> > +   default y
> > +   select HAS_VUART
> 
> This is questionable too (for still being controlled by a prompt), but
> may need to remain as is.
> 
> Jan