Re: [PATCH] xen/efi: Show error message for EFI_INVALID_PARAMETER error

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Jun 24, 2025 at 07:35:39AM +0100, Frediano Ziglio wrote:
> Show string message instead of code.
> This happened trying some different ways to boot Xen, specifically
> trying loading xen.efi using GRUB2 "linux" command.
> 
> Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxx>

Acked-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

> ---
>  xen/common/efi/boot.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> index fb3b120982..ded7cc129d 100644
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -329,6 +329,9 @@ static void __init PrintErrMesg(const CHAR16 *mesg, 
> EFI_STATUS ErrCode)
>      case EFI_BUFFER_TOO_SMALL:
>          mesg = L"Buffer too small";
>          break;
> +    case EFI_INVALID_PARAMETER:
> +        mesg = L"Invalid parameter";
> +        break;
>      default:
>          PrintErr(L"ErrCode: ");
>          DisplayUint(ErrCode, 0);
> -- 
> 2.43.0
> 

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature